Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js

Summary

Maintainability
F
4 days
Test Coverage

Function editDistributionCircuit has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      $scope.editDistributionCircuit = function(distributioncircuit) {
          var modalInstance = $uibModal.open({
              templateUrl: 'views/settings/distributionsystem/distributioncircuit.model.html',
              controller: 'ModalEditDistributionCircuitCtrl',
            windowClass: "animated fadeIn",
Severity: Minor
Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js - About 1 hr to fix

    Function addDistributionCircuit has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          $scope.addDistributionCircuit = function() {

          var modalInstance = $uibModal.open({
              templateUrl: 'views/settings/distributionsystem/distributioncircuit.model.html',
              controller: 'ModalAddDistributionCircuitCtrl',
    Severity: Minor
    Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js - About 1 hr to fix

      Function deleteDistributionCircuit has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            $scope.deleteDistributionCircuit = function(distributioncircuit) {
          SweetAlert.swal({
                  title: $translate.instant("SWEET.TITLE"),
                  text: $translate.instant("SWEET.TEXT"),
                  type: "warning",
      Severity: Minor
      Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  modalInstance.result.then(function(distributioncircuit) {
        distributioncircuit.distribution_system_id = $scope.currentDistributionSystem.id;
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
              DistributionCircuitService.addDistributionCircuit(distributioncircuit, headers, function (response) {
                  if (angular.isDefined(response.status) && response.status === 201) {
        Severity: Major
        Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js and 1 other location - About 1 day to fix
        myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js on lines 101..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 278.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  modalInstance.result.then(function(modifiedDistributionCircuit) {
        modifiedDistributionCircuit.distribution_system_id = $scope.currentDistributionSystem.id;
            let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
              DistributionCircuitService.editDistributionCircuit(modifiedDistributionCircuit, headers, function (response) {
                  if (angular.isDefined(response.status) && response.status === 200) {
        Severity: Major
        Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js and 1 other location - About 1 day to fix
        myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js on lines 59..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 278.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 12 locations. Consider refactoring.
        Open

          app.controller('ModalEditDistributionCircuitCtrl', function($scope, $uibModalInstance, params) {
      $scope.operation = "DISTRIBUTION_SYSTEM.EDIT_DISTRIBUTION_CIRCUIT";
      $scope.distributioncircuit = params.distributioncircuit;
      $scope.ok = function() {
          $uibModalInstance.close($scope.distributioncircuit);
        Severity: Major
        Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js and 11 other locations - About 3 hrs to fix
        myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 148..159
        myems-admin/app/controllers/settings/contact/contact.controller.js on lines 145..156
        myems-admin/app/controllers/settings/distributionsystem/distributionsystem.controller.js on lines 256..266
        myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 143..154
        myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js on lines 243..254
        myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramnode.controller.js on lines 188..198
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js on lines 273..284
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerhvac.controller.js on lines 382..393
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerschedule.controller.js on lines 152..162
        myems-admin/app/controllers/settings/menu/menu.controller.js on lines 151..162
        myems-admin/app/controllers/settings/svg/svg.controller.js on lines 244..255

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

          app.controller('ModalAddDistributionCircuitCtrl', function($scope, $uibModalInstance, params) {

      $scope.operation = "DISTRIBUTION_SYSTEM.ADD_DISTRIBUTION_CIRCUIT";

      $scope.ok = function() {
        Severity: Major
        Found in myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js and 6 other locations - About 2 hrs to fix
        myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramnode.controller.js on lines 174..186
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerschedule.controller.js on lines 140..150
        myems-admin/app/controllers/settings/gateway/gateway.controller.js on lines 241..251
        myems-admin/app/controllers/settings/protocol/protocol.controller.js on lines 241..251
        myems-admin/app/controllers/settings/sensor/sensor.controller.js on lines 242..252
        myems-admin/app/controllers/settings/workingcalendar/workingcalendar.controller.js on lines 241..251

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status