Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js

Summary

Maintainability
F
5 days
Test Coverage

Function editEnergyFlowDiagram has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.editEnergyFlowDiagram = function(energyflowdiagram) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/energyflowdiagram/energyflowdiagram.model.html',
            controller: 'ModalEditEnergyFlowDiagramCtrl',
Severity: Minor
Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js - About 1 hr to fix

    Function importEnergyFlowDiagram has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.importEnergyFlowDiagram = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/common/import.html',
            controller: 'ModalImportCtrl',
            windowClass: "animated fadeIn",
    Severity: Minor
    Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js - About 1 hr to fix

      Function deleteEnergyFlowDiagram has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.deleteEnergyFlowDiagram=function(energyflowdiagram){
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
      Severity: Minor
      Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js - About 1 hr to fix

        Function addEnergyFlowDiagram has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.addEnergyFlowDiagram = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/energyflowdiagram/energyflowdiagram.model.html',
            controller: 'ModalAddEnergyFlowDiagramCtrl',
            windowClass: "animated fadeIn",
        Severity: Minor
        Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $scope.editEnergyFlowDiagram = function(energyflowdiagram) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/energyflowdiagram/energyflowdiagram.model.html',
            controller: 'ModalEditEnergyFlowDiagramCtrl',
          Severity: Major
          Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js and 1 other location - About 2 days to fix
          myems-admin/app/controllers/settings/svg/svg.controller.js on lines 60..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 364.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              $scope.addEnergyFlowDiagram = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/energyflowdiagram/energyflowdiagram.model.html',
            controller: 'ModalAddEnergyFlowDiagramCtrl',
            windowClass: "animated fadeIn",
          Severity: Major
          Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js and 3 other locations - About 1 day to fix
          myems-admin/app/controllers/settings/command/command.controller.js on lines 27..58
          myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 24..55
          myems-admin/app/controllers/settings/svg/svg.controller.js on lines 27..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 328.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 12 locations. Consider refactoring.
          Open

          app.controller("ModalEditEnergyFlowDiagramCtrl", function($scope, $uibModalInstance,  params) {
  $scope.operation = "ENERGY_FLOW_DIAGRAM.EDIT_ENERGY_FLOW_DIAGRAM";
  $scope.energyflowdiagram = params.energyflowdiagram;

  $scope.ok = function() {
          Severity: Major
          Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js and 11 other locations - About 3 hrs to fix
          myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 148..159
          myems-admin/app/controllers/settings/contact/contact.controller.js on lines 145..156
          myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js on lines 189..199
          myems-admin/app/controllers/settings/distributionsystem/distributionsystem.controller.js on lines 256..266
          myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 143..154
          myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramnode.controller.js on lines 188..198
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js on lines 273..284
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerhvac.controller.js on lines 382..393
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerschedule.controller.js on lines 152..162
          myems-admin/app/controllers/settings/menu/menu.controller.js on lines 151..162
          myems-admin/app/controllers/settings/svg/svg.controller.js on lines 244..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          app.controller("ModalAddEnergyFlowDiagramCtrl", function(  $scope,  $uibModalInstance) {
  $scope.operation = "ENERGY_FLOW_DIAGRAM.ADD_ENERGY_FLOW_DIAGRAM";
  $scope.ok = function() {
    $uibModalInstance.close($scope.energyflowdiagram);
  };
          Severity: Major
          Found in myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js and 3 other locations - About 2 hrs to fix
          myems-admin/app/controllers/settings/command/command.controller.js on lines 256..265
          myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 141..150
          myems-admin/app/controllers/settings/svg/svg.controller.js on lines 233..242

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status