myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramlink.controller.js

Summary

Maintainability
D
2 days
Test Coverage

File energyflowdiagramlink.controller.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('EnergyFlowDiagramLinkController', function(
    $scope,
    $rootScope,

    Function editEnergyFlowDiagramLink has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.editEnergyFlowDiagramLink = function(energyflowdiagramlink) {
            var modalInstance = $uibModal.open({
                templateUrl: 'views/settings/energyflowdiagram/energyflowdiagramlink.model.html',
                controller: 'ModalEditEnergyFlowDiagramLinkCtrl',
                  windowClass: "animated fadeIn",

      Function addEnergyFlowDiagramLink has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.addEnergyFlowDiagramLink = function() {
      
              var modalInstance = $uibModal.open({
                  templateUrl: 'views/settings/energyflowdiagram/energyflowdiagramlink.model.html',
                  controller: 'ModalAddEnergyFlowDiagramLinkCtrl',

        Function getMergedMeters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.getMergedMeters = function() {
                $scope.mergedmeters = [];
                $scope.meters = [];
                $scope.offlinemeters = [];
                $scope.virtualmeters = [];

          Function deleteEnergyFlowDiagramLink has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.deleteEnergyFlowDiagramLink = function(energyflowdiagramlink) {
                  SweetAlert.swal({
                          title: $translate.instant("SWEET.TITLE"),
                          text: $translate.instant("SWEET.TEXT"),
                          type: "warning",

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        EnergyFlowDiagramLinkService.addEnergyFlowDiagramLink(energyflowdiagramid, energyflowdiagramlink, headers, function (response) {
                            if (angular.isDefined(response.status) && response.status === 201) {
                                toaster.pop({
                                    type: "success",
                                    title: $translate.instant("TOASTER.SUCCESS_TITLE"),
            myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramnode.controller.js on lines 62..80

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 219.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 19 locations. Consider refactoring.
            Open

            app.controller('ModalEditEnergyFlowDiagramLinkCtrl', function($scope, $uibModalInstance, params) {
                $scope.operation = "ENERGY_FLOW_DIAGRAM.EDIT_LINK";
                $scope.energyflowdiagramlink = params.energyflowdiagramlink;
                $scope.energyflowdiagramnodes = params.energyflowdiagramnodes;
                $scope.mergedmeters = params.mergedmeters;
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js on lines 199..212
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 462..474
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 387..399
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 379..391
            myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerpowerconversionsystem.controller.js on lines 684..697
            myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 229..241
            myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 221..233
            myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 221..233
            myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 224..236
            myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 226..238
            myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 221..233
            myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 222..234
            myems-admin/app/controllers/settings/microgrid/microgridpowerconversionsystem.controller.js on lines 232..245
            myems-admin/app/controllers/settings/photovoltaicpowerstation/photovoltaicpowerstation.controller.js on lines 290..303
            myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 295..308
            myems-admin/app/controllers/settings/store/store.controller.js on lines 297..310
            myems-admin/app/controllers/settings/virtualpowerplant/virtualpowerplant.controller.js on lines 290..304
            myems-admin/app/controllers/settings/windfarm/windfarm.controller.js on lines 290..303

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 134.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status