Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js

Summary

Maintainability
F
5 days
Test Coverage

Function editEnergyStorageContainer has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.editEnergyStorageContainer = function(energystoragecontainer) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/energystoragecontainer/energystoragecontainer.model.html',
            controller: 'ModalEditEnergyStorageContainerCtrl',
Severity: Minor
Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js - About 1 hr to fix

    Function addEnergyStorageContainer has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.addEnergyStorageContainer = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/energystoragecontainer/energystoragecontainer.model.html',
            controller: 'ModalAddEnergyStorageContainerCtrl',
            windowClass: "animated fadeIn",
    Severity: Minor
    Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js - About 1 hr to fix

      Function deleteEnergyStorageContainer has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.deleteEnergyStorageContainer=function(energystoragecontainer){
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
      Severity: Minor
      Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                modalInstance.result.then(function(energystoragecontainer) {
            energystoragecontainer.cost_center_id = energystoragecontainer.cost_center.id;
            energystoragecontainer.contact_id = energystoragecontainer.contact.id;
            if (angular.isDefined(energystoragecontainer.svg) && angular.isDefined(energystoragecontainer.svg.id)) {
                energystoragecontainer.svg_id = energystoragecontainer.svg.id;
        Severity: Major
        Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js and 1 other location - About 1 day to fix
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js on lines 123..149

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 336.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                modalInstance.result.then(function(modifiedEnergyStorageContainer) {
            modifiedEnergyStorageContainer.cost_center_id=modifiedEnergyStorageContainer.cost_center.id;
            modifiedEnergyStorageContainer.contact_id=modifiedEnergyStorageContainer.contact.id;
            if (angular.isDefined(modifiedEnergyStorageContainer.svg) && angular.isDefined(modifiedEnergyStorageContainer.svg.id)) {
                modifiedEnergyStorageContainer.svg_id = modifiedEnergyStorageContainer.svg.id;
        Severity: Major
        Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js and 1 other location - About 1 day to fix
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js on lines 75..100

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 336.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        app.controller('ModalEditEnergyStorageContainerCtrl', function($scope, $uibModalInstance, params) {
    $scope.operation = "SETTING.EDIT_ENERGY_STORAGE_CONTAINER";
    $scope.energystoragecontainer = params.energystoragecontainer;
    $scope.costcenters=params.costcenters;
    $scope.contacts=params.contacts;
        Severity: Major
        Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js and 7 other locations - About 5 hrs to fix
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerpowerconversionsystem.controller.js on lines 699..712
        myems-admin/app/controllers/settings/microgrid/microgridpowerconversionsystem.controller.js on lines 247..260
        myems-admin/app/controllers/settings/photovoltaicpowerstation/photovoltaicpowerstation.controller.js on lines 305..318
        myems-admin/app/controllers/settings/space/space.controller.js on lines 400..414
        myems-admin/app/controllers/settings/store/store.controller.js on lines 312..325
        myems-admin/app/controllers/settings/virtualpowerplant/virtualpowerplant.controller.js on lines 306..320
        myems-admin/app/controllers/settings/windfarm/windfarm.controller.js on lines 305..318

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 149.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 19 locations. Consider refactoring.
        Open

        app.controller('ModalAddEnergyStorageContainerCtrl', function($scope, $uibModalInstance,params) {

    $scope.operation = "SETTING.ADD_ENERGY_STORAGE_CONTAINER";
    $scope.costcenters=params.costcenters;
    $scope.contacts=params.contacts;
        Severity: Major
        Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js and 18 other locations - About 4 hrs to fix
        myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramlink.controller.js on lines 304..316
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 462..474
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 387..399
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 379..391
        myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerpowerconversionsystem.controller.js on lines 684..697
        myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 229..241
        myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 221..233
        myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 221..233
        myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 224..236
        myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 226..238
        myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 221..233
        myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 222..234
        myems-admin/app/controllers/settings/microgrid/microgridpowerconversionsystem.controller.js on lines 232..245
        myems-admin/app/controllers/settings/photovoltaicpowerstation/photovoltaicpowerstation.controller.js on lines 290..303
        myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 295..308
        myems-admin/app/controllers/settings/store/store.controller.js on lines 297..310
        myems-admin/app/controllers/settings/virtualpowerplant/virtualpowerplant.controller.js on lines 290..304
        myems-admin/app/controllers/settings/windfarm/windfarm.controller.js on lines 290..303

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 134.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status