Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js

Summary

Maintainability
F
1 wk
Test Coverage

Function editEnergyStorageContainerFirecontrol has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      $scope.editEnergyStorageContainerFirecontrol = function(energystoragecontainerfirecontrol) {
          var modalInstance = $uibModal.open({
              templateUrl: 'views/settings/energystoragecontainer/energystoragecontainerfirecontrol.model.html',
              controller: 'ModalEditEnergyStorageContainerFirecontrolCtrl',
            windowClass: "animated fadeIn",
Severity: Major
Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js - About 3 hrs to fix

    Function addEnergyStorageContainerFirecontrol has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          $scope.addEnergyStorageContainerFirecontrol = function() {

          var modalInstance = $uibModal.open({
              templateUrl: 'views/settings/energystoragecontainer/energystoragecontainerfirecontrol.model.html',
              controller: 'ModalAddEnergyStorageContainerFirecontrolCtrl',
    Severity: Major
    Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js - About 3 hrs to fix

      File energystoragecontainerfirecontrol.controller.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';

app.controller('EnergyStorageContainerFirecontrolController', function(
    $scope,
    $rootScope,
      Severity: Minor
      Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js - About 2 hrs to fix

        Function deleteEnergyStorageContainerFirecontrol has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              $scope.deleteEnergyStorageContainerFirecontrol = function(energystoragecontainerfirecontrol) {
          SweetAlert.swal({
                  title: $translate.instant("SWEET.TITLE"),
                  text: $translate.instant("SWEET.TEXT"),
                  type: "warning",
        Severity: Minor
        Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    modalInstance.result.then(function(modifiedEnergyStorageContainerFirecontrol) {
            if (modifiedEnergyStorageContainerFirecontrol.inside_temperature_point != null && modifiedEnergyStorageContainerFirecontrol.inside_temperature_point.id != null ) {
                modifiedEnergyStorageContainerFirecontrol.inside_temperature_point_id = modifiedEnergyStorageContainerFirecontrol.inside_temperature_point.id;
            } else {
                modifiedEnergyStorageContainerFirecontrol.inside_temperature_point_id = undefined;
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js and 1 other location - About 4 days to fix
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js on lines 73..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 788.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    modalInstance.result.then(function(energystoragecontainerfirecontrol) {
            if (energystoragecontainerfirecontrol.inside_temperature_point != null && energystoragecontainerfirecontrol.inside_temperature_point.id != null ) {
                energystoragecontainerfirecontrol.inside_temperature_point_id = energystoragecontainerfirecontrol.inside_temperature_point.id;
            } else {
                energystoragecontainerfirecontrol.inside_temperature_point_id = undefined;
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js and 1 other location - About 4 days to fix
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js on lines 156..220

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 788.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 24 locations. Consider refactoring.
          Open

            app.controller('ModalEditEnergyStorageContainerFirecontrolCtrl', function($scope, $uibModalInstance, params) {
      $scope.operation = "ENERGY_STORAGE_CONTAINER.EDIT_ENERGY_STORAGE_CONTAINER_FIRECONTROL";
      $scope.energystoragecontainerfirecontrol = params.energystoragecontainerfirecontrol;
    $scope.points=params.points;
      $scope.ok = function() {
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js and 23 other locations - About 4 hrs to fix
          myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 161..173
          myems-admin/app/controllers/settings/category/energyitem.controller.js on lines 164..175
          myems-admin/app/controllers/settings/command/command.controller.js on lines 267..279
          myems-admin/app/controllers/settings/contact/contact.controller.js on lines 158..170
          myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 152..164
          myems-admin/app/controllers/settings/distributionsystem/distributionsystem.controller.js on lines 268..280
          myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 156..168
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 448..460
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 246..258
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerhvac.controller.js on lines 395..406
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 241..253
          myems-admin/app/controllers/settings/gateway/gateway.controller.js on lines 253..264
          myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 215..227
          myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 207..219
          myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 207..219
          myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 210..222
          myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 212..224
          myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 207..219
          myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 208..220
          myems-admin/app/controllers/settings/protocol/protocol.controller.js on lines 253..264
          myems-admin/app/controllers/settings/sensor/sensor.controller.js on lines 254..265
          myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 281..293
          myems-admin/app/controllers/settings/workingcalendar/workingcalendar.controller.js on lines 253..264

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 12 locations. Consider refactoring.
          Open

            app.controller('ModalAddEnergyStorageContainerFirecontrolCtrl', function($scope, $uibModalInstance, params) {

      $scope.operation = "ENERGY_STORAGE_CONTAINER.ADD_ENERGY_STORAGE_CONTAINER_FIRECONTROL";
    $scope.points=params.points;
      $scope.ok = function() {
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js and 11 other locations - About 3 hrs to fix
          myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 148..159
          myems-admin/app/controllers/settings/contact/contact.controller.js on lines 145..156
          myems-admin/app/controllers/settings/distributionsystem/distributioncircuit.controller.js on lines 189..199
          myems-admin/app/controllers/settings/distributionsystem/distributionsystem.controller.js on lines 256..266
          myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 143..154
          myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagram.controller.js on lines 243..254
          myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramnode.controller.js on lines 188..198
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerhvac.controller.js on lines 382..393
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerschedule.controller.js on lines 152..162
          myems-admin/app/controllers/settings/menu/menu.controller.js on lines 151..162
          myems-admin/app/controllers/settings/svg/svg.controller.js on lines 244..255

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status