Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js

Summary

Maintainability
F
2 wks
Test Coverage

File energystoragecontainergrid.controller.js has 377 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('EnergyStorageContainerGridController', function(
    $scope,
    $rootScope,
Severity: Minor
Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js - About 5 hrs to fix

    Function editEnergyStorageContainerGrid has 121 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          $scope.editEnergyStorageContainerGrid = function(energystoragecontainergrid) {
          var modalInstance = $uibModal.open({
              templateUrl: 'views/settings/energystoragecontainer/energystoragecontainergrid.model.html',
              controller: 'ModalEditEnergyStorageContainerGridCtrl',
            windowClass: "animated fadeIn",
    Severity: Major
    Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js - About 4 hrs to fix

      Function addEnergyStorageContainerGrid has 120 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            $scope.addEnergyStorageContainerGrid = function() {

          var modalInstance = $uibModal.open({
              templateUrl: 'views/settings/energystoragecontainer/energystoragecontainergrid.model.html',
              controller: 'ModalAddEnergyStorageContainerGridCtrl',
      Severity: Major
      Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js - About 4 hrs to fix

        Function deleteEnergyStorageContainerGrid has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              $scope.deleteEnergyStorageContainerGrid = function(energystoragecontainergrid) {
          SweetAlert.swal({
                  title: $translate.instant("SWEET.TITLE"),
                  text: $translate.instant("SWEET.TEXT"),
                  type: "warning",
        Severity: Minor
        Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    modalInstance.result.then(function(modifiedEnergyStorageContainerGrid) {
            modifiedEnergyStorageContainerGrid.power_point_id = modifiedEnergyStorageContainerGrid.power_point.id;
            modifiedEnergyStorageContainerGrid.buy_meter_id = modifiedEnergyStorageContainerGrid.buy_meter.id;
            modifiedEnergyStorageContainerGrid.sell_meter_id = modifiedEnergyStorageContainerGrid.sell_meter.id;
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js and 1 other location - About 1 wk to fix
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 86..191

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1365.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    modalInstance.result.then(function(energystoragecontainergrid) {
            energystoragecontainergrid.power_point_id = energystoragecontainergrid.power_point.id;
            energystoragecontainergrid.buy_meter_id = energystoragecontainergrid.buy_meter.id;
            energystoragecontainergrid.sell_meter_id = energystoragecontainergrid.sell_meter.id;
            if (energystoragecontainergrid.total_active_power_point != null && energystoragecontainergrid.total_active_power_point.id != null ) {
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js and 1 other location - About 1 wk to fix
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js on lines 213..319

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 1365.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 19 locations. Consider refactoring.
          Open

            app.controller('ModalEditEnergyStorageContainerGridCtrl', function($scope, $uibModalInstance, params) {
      $scope.operation = "ENERGY_STORAGE_CONTAINER.EDIT_ENERGY_STORAGE_CONTAINER_GRID";
      $scope.energystoragecontainergrid = params.energystoragecontainergrid;
    $scope.points=params.points;
    $scope.meters=params.meters;
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js and 18 other locations - About 4 hrs to fix
          myems-admin/app/controllers/settings/energyflowdiagram/energyflowdiagramlink.controller.js on lines 304..316
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainer.controller.js on lines 199..212
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 462..474
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 379..391
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerpowerconversionsystem.controller.js on lines 684..697
          myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 229..241
          myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 221..233
          myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 221..233
          myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 224..236
          myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 226..238
          myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 221..233
          myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 222..234
          myems-admin/app/controllers/settings/microgrid/microgridpowerconversionsystem.controller.js on lines 232..245
          myems-admin/app/controllers/settings/photovoltaicpowerstation/photovoltaicpowerstation.controller.js on lines 290..303
          myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 295..308
          myems-admin/app/controllers/settings/store/store.controller.js on lines 297..310
          myems-admin/app/controllers/settings/virtualpowerplant/virtualpowerplant.controller.js on lines 290..304
          myems-admin/app/controllers/settings/windfarm/windfarm.controller.js on lines 290..303

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 134.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 24 locations. Consider refactoring.
          Open

            app.controller('ModalAddEnergyStorageContainerGridCtrl', function($scope, $uibModalInstance, params) {

      $scope.operation = "ENERGY_STORAGE_CONTAINER.ADD_ENERGY_STORAGE_CONTAINER_GRID";
    $scope.points=params.points;
    $scope.meters=params.meters;
          Severity: Major
          Found in myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainergrid.controller.js and 23 other locations - About 4 hrs to fix
          myems-admin/app/controllers/settings/category/energycategory.controller.js on lines 161..173
          myems-admin/app/controllers/settings/category/energyitem.controller.js on lines 164..175
          myems-admin/app/controllers/settings/command/command.controller.js on lines 267..279
          myems-admin/app/controllers/settings/contact/contact.controller.js on lines 158..170
          myems-admin/app/controllers/settings/costcenter/costcenter.controller.js on lines 152..164
          myems-admin/app/controllers/settings/distributionsystem/distributionsystem.controller.js on lines 268..280
          myems-admin/app/controllers/settings/emailserver/emailserver.controller.js on lines 156..168
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerbattery.controller.js on lines 448..460
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerfirecontrol.controller.js on lines 286..297
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerhvac.controller.js on lines 395..406
          myems-admin/app/controllers/settings/energystoragecontainer/energystoragecontainerload.controller.js on lines 365..377
          myems-admin/app/controllers/settings/gateway/gateway.controller.js on lines 253..264
          myems-admin/app/controllers/settings/microgrid/microgridbattery.controller.js on lines 215..227
          myems-admin/app/controllers/settings/microgrid/microgridevcharger.controller.js on lines 207..219
          myems-admin/app/controllers/settings/microgrid/microgridgenerator.controller.js on lines 207..219
          myems-admin/app/controllers/settings/microgrid/microgridgrid.controller.js on lines 210..222
          myems-admin/app/controllers/settings/microgrid/microgridheatpump.controller.js on lines 212..224
          myems-admin/app/controllers/settings/microgrid/microgridload.controller.js on lines 207..219
          myems-admin/app/controllers/settings/microgrid/microgridphotovoltaic.controller.js on lines 208..220
          myems-admin/app/controllers/settings/protocol/protocol.controller.js on lines 253..264
          myems-admin/app/controllers/settings/sensor/sensor.controller.js on lines 254..265
          myems-admin/app/controllers/settings/shopfloor/shopfloor.controller.js on lines 281..293
          myems-admin/app/controllers/settings/workingcalendar/workingcalendar.controller.js on lines 253..264

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status