Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js

Summary

Maintainability
F
2 wks
Test Coverage

File equipmentparameter.controller.js has 299 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('EquipmentParameterController', function(
    $scope,
    $rootScope,
Severity: Minor
Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js - About 3 hrs to fix

    Function editEquipmentParameter has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.editEquipmentParameter = function(equipmentparameter) {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/equipment/equipmentparameter.model.html',
            controller: 'ModalEditEquipmentParameterCtrl',
          windowClass: "animated fadeIn",
    Severity: Minor
    Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js - About 1 hr to fix

      Function addEquipmentParameter has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.addEquipmentParameter = function() {

        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/equipment/equipmentparameter.model.html',
            controller: 'ModalAddEquipmentParameterCtrl',
      Severity: Minor
      Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js - About 1 hr to fix

        Function getMergedMeters has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.getMergedMeters = function() {
        $scope.mergedmeters = [];
        $scope.meters = [];
        $scope.offlinemeters = [];
        $scope.virtualmeters = [];
        Severity: Minor
        Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js - About 1 hr to fix

          Function deleteEquipmentParameter has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.deleteEquipmentParameter = function(equipmentparameter) {
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
          Severity: Minor
          Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            app.controller('EquipmentParameterController', function(
    $scope,
    $rootScope,
    $window,
    $uibModal,
            Severity: Major
            Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js and 1 other location - About 2 wks to fix
            myems-admin/app/controllers/settings/combinedequipment/combinedequipmentparameter.controller.js on lines 3..291

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 2916.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            app.controller('ModalAddEquipmentParameterCtrl', function($scope, $uibModalInstance, params) {

    $scope.operation = "EQUIPMENT.ADD_PARAMETER";
    $scope.equipmentparameter = {
      parameter_type : "constant",
            Severity: Major
            Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js and 1 other location - About 5 hrs to fix
            myems-admin/app/controllers/settings/combinedequipment/combinedequipmentparameter.controller.js on lines 294..311

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 147.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            app.controller('ModalEditEquipmentParameterCtrl', function($scope, $uibModalInstance, params) {
    $scope.operation = "EQUIPMENT.EDIT_PARAMETER";
    $scope.equipmentparameter = params.equipmentparameter;
    $scope.points = params.points;
    $scope.mergedmeters = params.mergedmeters;
            Severity: Major
            Found in myems-admin/app/controllers/settings/equipment/equipmentparameter.controller.js and 1 other location - About 5 hrs to fix
            myems-admin/app/controllers/settings/combinedequipment/combinedequipmentparameter.controller.js on lines 313..326

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 145.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status