Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/settings/tariff/tariff.controller.js

Summary

Maintainability
F
1 wk
Test Coverage

File tariff.controller.js has 399 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

app.controller('TariffController', function(
    $scope,
    $rootScope,
Severity: Minor
Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js - About 5 hrs to fix

    Function editTariff has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.editTariff = function(tariff) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/settings/tariff/tariff.model.html',
            controller: 'ModalEditTariffCtrl',
    Severity: Minor
    Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js - About 1 hr to fix

      Function addTariff has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.addTariff = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/settings/tariff/tariff.model.html',
            controller: 'ModalAddTariffCtrl',
            windowClass: "animated fadeIn",
      Severity: Minor
      Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js - About 1 hr to fix

        Function deleteTariff has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.deleteTariff = function(tariff) {
        SweetAlert.swal({
                title: $translate.instant("SWEET.TITLE"),
                text: $translate.instant("SWEET.TEXT"),
                type: "warning",
        Severity: Minor
        Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js - About 1 hr to fix

          Function importTariff has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.importTariff = function() {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/common/import.html',
            controller: 'ModalImportCtrl',
            windowClass: "animated fadeIn",
          Severity: Minor
          Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.add = function(t) {
        if (t.peak_type == null || t.price == null || t.peak_type == ''){
            return false;
        }
        t.start_time_of_day= t.start_hour + ':' + t.start_min + ':' + t.start_second;
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 1 other location - About 2 days to fix
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 396..422

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 389.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.add = function(t) {
        if (t.peak_type == null || t.price == null || t.peak_type == ''){
            return false;
        }
        t.start_time_of_day= t.start_hour + ':' + t.start_min + ':' + t.start_second;
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 1 other location - About 2 days to fix
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 311..337

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 389.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                $scope.ok = function() {
        $scope.tariff.valid_from=moment($scope.tariff.valid_from).format().slice(0,19);
        $scope.tariff.valid_through=moment($scope.tariff.valid_through).format().slice(0,19);
        $uibModalInstance.close($scope.tariff);
    };
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 3 other locations - About 4 hrs to fix
            myems-admin/app/controllers/settings/tenant/tenant.controller.js on lines 327..331
            myems-admin/app/controllers/settings/tenant/tenant.controller.js on lines 355..359
            myems-admin/app/controllers/users/apikey/apikey.controller.js on lines 222..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.delete = function(key) {
        if($scope.tariff.tariff_type=='timeofuse'){
            $scope.timeofuse.splice(key, 1);
            $timeout(function() {
                angular.element('#touTable').trigger('footable_redraw');
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 1 other location - About 2 hrs to fix
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 338..345

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.delete = function(key) {
        if($scope.tariff.tariff_type=='timeofuse'){
            $scope.timeofuse.splice(key, 1);
            $timeout(function() {
                angular.element('#touTable').trigger('footable_redraw');
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 1 other location - About 2 hrs to fix
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 424..431

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                $scope.dtOptions = {
        locale:{
            format: 'YYYY-MM-DD HH:mm:ss',
            applyLabel: "OK",
            cancelLabel: "Cancel",
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 3 other locations - About 1 hr to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 276..287
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 304..315
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 283..294

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

                $scope.dtOptions = {
        locale:{
            format: 'YYYY-MM-DD HH:mm:ss',
            applyLabel: "OK",
            cancelLabel: "Cancel",
            Severity: Major
            Found in myems-admin/app/controllers/settings/tariff/tariff.controller.js and 3 other locations - About 1 hr to fix
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 276..287
            myems-admin/app/controllers/settings/advancedreport/advancedreport.controller.js on lines 304..315
            myems-admin/app/controllers/settings/tariff/tariff.controller.js on lines 363..374

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status