Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/app/controllers/users/privilege/privilege.controller.js

Summary

Maintainability
C
1 day
Test Coverage

Function editPrivilege has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $scope.editPrivilege = function (privilege) {
        var modalInstance = $uibModal.open({
            windowClass: "animated fadeIn",
            templateUrl: 'views/users/privilege/privilege.model.html',
            controller: 'ModalEditPrivilegeCtrl',
Severity: Minor
Found in myems-admin/app/controllers/users/privilege/privilege.controller.js - About 1 hr to fix

    Function addPrivilege has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $scope.addPrivilege = function () {
        var modalInstance = $uibModal.open({
            templateUrl: 'views/users/privilege/privilege.model.html',
            controller: 'ModalAddPrivilegeCtrl',
            windowClass: "animated fadeIn",
    Severity: Minor
    Found in myems-admin/app/controllers/users/privilege/privilege.controller.js - About 1 hr to fix

      Function deletePrivilege has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $scope.deletePrivilege = function (privilege) {
        SweetAlert.swal({
            title: $translate.instant("SWEET.TITLE"),
            text: $translate.instant("SWEET.TEXT"),
            type: "warning",
      Severity: Minor
      Found in myems-admin/app/controllers/users/privilege/privilege.controller.js - About 1 hr to fix

        Function getAllSpaces has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $scope.getAllSpaces = function () {
        let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
        SpaceService.getAllSpaces(headers, function (response) {
            if (angular.isDefined(response.status) && response.status === 200) {
                $scope.spaces = response.data;
        Severity: Minor
        Found in myems-admin/app/controllers/users/privilege/privilege.controller.js - About 1 hr to fix

          Function getAllSpaces has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $scope.getAllSpaces = function () {
        let headers = { "User-UUID": $scope.cur_user.uuid, "Token": $scope.cur_user.token };
        SpaceService.getAllSpaces(headers, function (response) {
            if (angular.isDefined(response.status) && response.status === 200) {
                $scope.spaces = response.data;
          Severity: Minor
          Found in myems-admin/app/controllers/users/privilege/privilege.controller.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.ok = function () {
        $scope.privilege.data = JSON.stringify({"spaces": [$scope.currentSpaceID, ]});
        $uibModalInstance.close($scope.privilege);
    };
            Severity: Major
            Found in myems-admin/app/controllers/users/privilege/privilege.controller.js and 1 other location - About 1 hr to fix
            myems-admin/app/controllers/users/privilege/privilege.controller.js on lines 195..198

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                $scope.ok = function () {
        $scope.privilege.data = JSON.stringify({"spaces": [$scope.currentSpaceID, ]});
        $uibModalInstance.close($scope.privilege);
    };
            Severity: Major
            Found in myems-admin/app/controllers/users/privilege/privilege.controller.js and 1 other location - About 1 hr to fix
            myems-admin/app/controllers/users/privilege/privilege.controller.js on lines 255..258

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        angular.element(spacetree).on("changed.jstree", function (e, data) {
                $scope.currentSpaceID = parseInt(data.selected[0]);
            });
            Severity: Minor
            Found in myems-admin/app/controllers/users/privilege/privilege.controller.js and 1 other location - About 50 mins to fix
            myems-admin/app/controllers/users/privilege/privilege.controller.js on lines 189..191

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        angular.element(spacetree).on("changed.jstree", function (e, data) {
                $scope.currentSpaceID = parseInt(data.selected[0]);
            });
            Severity: Minor
            Found in myems-admin/app/controllers/users/privilege/privilege.controller.js and 1 other location - About 50 mins to fix
            myems-admin/app/controllers/users/privilege/privilege.controller.js on lines 249..251

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    "parent": ($scope.spaces[i].id == 1)? '#': $scope.spaces[i].parent_space.id.toString(),
            Severity: Minor
            Found in myems-admin/app/controllers/users/privilege/privilege.controller.js and 1 other location - About 45 mins to fix
            myems-admin/app/controllers/users/privilege/privilege.controller.js on lines 233..233

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    "parent": ($scope.spaces[i].id == 1)? '#': $scope.spaces[i].parent_space.id.toString(),
            Severity: Minor
            Found in myems-admin/app/controllers/users/privilege/privilege.controller.js and 1 other location - About 45 mins to fix
            myems-admin/app/controllers/users/privilege/privilege.controller.js on lines 240..240

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status