Sign upLogin

MyEMS/myems

View on GitHub
Star
myems-admin/js/angular/angular-messages.js

Summary

Maintainability
D
2 days
Test Coverage

Function NgMessagesCtrl has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      controller: ['$element', '$scope', '$attrs', function NgMessagesCtrl($element, $scope, $attrs) {
        var ctrl = this;
        var latestKey = 0;
        var nextAttachId = 0;
Severity: Major
Found in myems-admin/js/angular/angular-messages.js - About 5 hrs to fix

    Function ngMessageDirectiveFactory has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ngMessageDirectiveFactory(isDefault) {
  return ['$animate', function($animate) {
    return {
      restrict: 'AE',
      transclude: 'element',
    Severity: Major
    Found in myems-admin/js/angular/angular-messages.js - About 2 hrs to fix

      File angular-messages.js has 272 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /**
 * @license AngularJS v1.8.3
 * (c) 2010-2020 Google LLC. http://angularjs.org
 * License: MIT
 */
      Severity: Minor
      Found in myems-admin/js/angular/angular-messages.js - About 2 hrs to fix

        Function link has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              link: function(scope, element, attrs, ngMessagesCtrl, $transclude) {
        var commentNode, records, staticExp, dynamicExp;

        if (!isDefault) {
          commentNode = element[0];
        Severity: Major
        Found in myems-admin/js/angular/angular-messages.js - About 2 hrs to fix

          Function render has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  this.render = function(collection) {
          collection = collection || {};

          renderLater = false;
          cachedCollection = collection;
          Severity: Minor
          Found in myems-admin/js/angular/angular-messages.js - About 2 hrs to fix

            Avoid deeply nested control flow statements.
            Open

                                if (matchedKeys[key]) return;
            Severity: Major
            Found in myems-admin/js/angular/angular-messages.js - About 45 mins to fix

              Function link has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    link: function(scope, element, attrs, ngMessagesCtrl, $transclude) {
              Severity: Minor
              Found in myems-admin/js/angular/angular-messages.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (attachDefault) {
            ctrl.default.attach();
          } else if (ctrl.default) {
            ctrl.default.detach();
          }
                Severity: Minor
                Found in myems-admin/js/angular/angular-messages.js and 1 other location - About 35 mins to fix
                myems-admin/js/angular-highcharts/highcharts-ng.js on lines 441..445

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status