NLeSC/Cesium-NcWMS

Function CustomGraphController has 374 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function CustomGraphController($scope, $window, $timeout, $http, d3Service, NcwmsService, Messagebus, UserAgent) {
    this.mobile = UserAgent.mobile;
    
    this.selectedLabel = '';
    this.selectedUnits = '';

Function init has 299 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this.init = function(element, attrs) {
      this.dragging = false;

      var container = element.children[0].children[1];
      var hoverContainer, hoverLine, hoverLineXOffset, hoverLineYOffset, hoverLineGroup,

Function render has 259 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        this.render = function(data) {
          // remove all previous items before render
          d3.select(container).selectAll('*').remove();

          if (!this.activated) {

File customgraph.controller.js has 380 lines of code (exceeds 250 allowed). Consider refactoring.

Open

(function() {
  'use strict';
  /*
    source: D3 example @ http://bl.ocks.org/rkirsling/33a9e350516da54a5d4f
  */

Function drawPaths has 86 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            this.drawPaths = function(svg, data, x, y, chartWidth, chartHeight) {
              var pathContainer = svg.append('g');

              var upperOuterArea = d3.svg.area()
                .interpolate('basis')

Function makeChart has 85 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            this.makeChart = function(data) {
              var svgWidth = width;
              var svgHeight = width / 2;
              var margin = {
                top: 20,

Function addAxesAndLegend has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            this.addAxesAndLegend = function(svg, xAxis, yAxis, margin, chartWidth, chartHeight) {
              var legendWidth = 0,
                legendHeight = 0;

              svg.append('clipPath')

Function CustomGraphController has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

  function CustomGraphController($scope, $window, $timeout, $http, d3Service, NcwmsService, Messagebus, UserAgent) {

Function addAxesAndLegend has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

            this.addAxesAndLegend = function(svg, xAxis, yAxis, margin, chartWidth, chartHeight) {

Function drawPaths has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

            this.drawPaths = function(svg, data, x, y, chartWidth, chartHeight) {

Similar blocks of code found in 4 locations. Consider refactoring.

Open

              var lowerOuterArea = d3.svg.area()
                .interpolate('basis')
                .x(function(d) {
                  return x(d.date) || 1;
                })

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

              var upperOuterArea = d3.svg.area()
                .interpolate('basis')
                .x(function(d) {
                  return x(d.date) || 1;
                }).y0(function(d) {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

              var upperInnerArea = d3.svg.area()
                .interpolate('basis')
                .x(function(d) {
                  return x(d.date) || 1;
                })

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

              var lowerInnerArea = d3.svg.area()
                .interpolate('basis')
                .x(function(d) {
                  return x(d.date) || 1;
                })

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

      Messagebus.subscribe('ncwmsDatasetSelected', function(event, value) {
        if (this.globalSelectedDataset !== value) {
          this.globalSelectedDataset = value;

          this.setSelections();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

              var xAxis = d3.svg.axis()
                .scale(x)
                .orient('bottom')
                .innerTickSize(-chartHeight)
                .outerTickSize(0)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

              var yAxis = d3.svg.axis()
                .scale(y)
                .orient('left')
                .innerTickSize(-chartWidth)
                .outerTickSize(0)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

              hoverLine = hoverLineGroup
                .append('line')
                .attr('x1', 10).attr('x2', 10) // vertical line so same value on each
                .attr('y1', 0).attr('y2', chartHeight); // top to bottom

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

              timeIndicatorLine = timeIndicatorLineGroup
                .append('line')
                .attr('x1', 10).attr('x2', 10) // vertical line so same value on each
                .attr('y1', 0).attr('y2', chartHeight); // top to bottom

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      Messagebus.subscribe('ncwmsPaletteSelected', function(event, value) {
        if (this.selectedPalette !== value) {
          this.selectedPalette = value;
        }
      }.bind(this));

• Read up
  Read up