NLeSC/Cesium-NcWMS

Function NcwmsService has 273 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function NcwmsService($q, $http, Messagebus) {
    this.ncWMSURL = 'http://localhost:8080/ncWMS-2.0-rc1-maartenvm/wms?';

    var deferred = $q.defer();
    this.ready = deferred.promise;

Function getFeatureInfoSeries has 94 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this.getFeatureInfoSeries = function(selectedDataset, selectedPalette, boundingRect, callbackSuccess, callbackFailure) {
      if (this.datasets.length === 0) {
        return;
      }

Function init has 77 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this.init = function() {
      // load JSON data
      $http.get('serverconfig.json').then(function(res) {
        if (res.data.id === 'ncWMS') {
          this.ncWMSURL = res.data.url;

File ncwms.service.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.

Open

(function() {
  'use strict';

  function NcwmsService($q, $http, Messagebus) {
    this.ncWMSURL = 'http://localhost:8080/ncWMS-2.0-rc1-maartenvm/wms?';

Function success has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        this.getMenu().then(function success(menuPromise) {
          // Build an array containing our datasets (--NG--)
          this.datasets = this.loadMenu(menuPromise);
          // Store the first dataset as our 'currently selected' dataset
          // (--NG--)

Function loadMenu has 52 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    this.loadMenu = function(menuPromiseResolve) {
      var result = [];

      this.ncWMSdata.metadata = menuPromiseResolve.data.children;
      menuPromiseResolve.data.children.forEach(function(dataset) {

Function getFeatureInfoSeries has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    this.getFeatureInfoSeries = function(selectedDataset, selectedPalette, boundingRect, callbackSuccess, callbackFailure) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (child.id.indexOf('stats_group') > -1) {
              //This is a stats group, so we will infer the min and max from the first child
              result.push({
                id: child.id,
                label: dataSetLabel + '/' + child.label,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if (grandChild.plottable) {
                  //The children of stats_groups are treated as normal datasets
                  result.push({
                    id: grandChild.id,
                    label: dataSetLabel + '/' + grandChild.label,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            } else {
              Messagebus.publish('graphMinChange', this.datasets[0].min);
              Messagebus.publish('graphMaxChange', this.datasets[0].max);
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (this.datasets[0].graphicalMin !== 0) {
              Messagebus.publish('graphMinChange', this.datasets[0].graphicalMin);
              Messagebus.publish('graphMaxChange', this.datasets[0].graphicalMax);
            } else {

• Read up
  Read up