Sign upLogin

NLeSC/PattyVis

View on GitHub
Star
app/scripts/pointcloud/path.controls.js

Summary

Maintainability
C
1 day
Test Coverage

File path.controls.js has 371 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 *  PathControls
 *  by Ben van Werkhoven (Netherlands eScience Center)
 *
 *  free look around with mouse drag
Severity: Minor
Found in app/scripts/pointcloud/path.controls.js - About 4 hrs to fix

    Function createPath has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        PathControls.prototype.createPath = function() {
        var tube = new THREE.TubeGeometry(path, 1024, 0.25, 8, false);
        var lookTube = new THREE.TubeGeometry(lookatPath, 1024, 0.25, 8, false);

        var tubeMesh = THREE.SceneUtils.createMultiMaterialObject( tube, [
    Severity: Minor
    Found in app/scripts/pointcloud/path.controls.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              var lookTubeMesh = THREE.SceneUtils.createMultiMaterialObject( lookTube, [
                new THREE.MeshLambertMaterial({
                    color: 0x0000ff
                }),
                new THREE.MeshBasicMaterial({
      Severity: Major
      Found in app/scripts/pointcloud/path.controls.js and 1 other location - About 1 hr to fix
      app/scripts/pointcloud/path.controls.js on lines 227..236

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              var tubeMesh = THREE.SceneUtils.createMultiMaterialObject( tube, [
                new THREE.MeshLambertMaterial({
                    color: 0x00ffff
                }),
                new THREE.MeshBasicMaterial({
      Severity: Major
      Found in app/scripts/pointcloud/path.controls.js and 1 other location - About 1 hr to fix
      app/scripts/pointcloud/path.controls.js on lines 237..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          PathControls.prototype.enableRailsMode = function() {
        this.transitionFromFlightMode();
    this.mode = this.modes.ONRAILS;
    this.messagebus.publish('pathModeChanged', this.mode);
    };
      Severity: Minor
      Found in app/scripts/pointcloud/path.controls.js and 1 other location - About 50 mins to fix
      app/scripts/pointcloud/path.controls.js on lines 417..421

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          } else {
      this.transitionFromFlightMode();
      this.mode = this.modes.DEMO;
      this.messagebus.publish('pathModeChanged', this.mode);
    }
      Severity: Minor
      Found in app/scripts/pointcloud/path.controls.js and 1 other location - About 50 mins to fix
      app/scripts/pointcloud/path.controls.js on lines 408..412

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status