Sign upLogin

NLeSC/ahn-pointcloud-viewer

View on GitHub
Star
app/scripts/pointcloud/gradients.service.js

Summary

Maintainability
F
1 mo
Test Coverage

Function GradientsService has 516 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function GradientsService() {
    Potree.Gradients.VIRIDIS = [
      [0, new THREE.Color(0.267, 0.0049, 0.3294)],
      [0.0039, new THREE.Color(0.2685, 0.0096, 0.3354)],
      [0.0078, new THREE.Color(0.2699, 0.0146, 0.3414)],
Severity: Major
Found in app/scripts/pointcloud/gradients.service.js - About 2 days to fix

    File gradients.service.js has 522 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function () {
  'use strict';
  /* global THREE:false, Potree:false  */

  function GradientsService() {
    Severity: Major
    Found in app/scripts/pointcloud/gradients.service.js - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Potree.Gradients.REALISTIC = [
      [0, new THREE.Color(1.0000, 1.0000, 0.9804)],
      [0.0039, new THREE.Color(0.9686, 0.9686, 0.9804)],
      [0.0078, new THREE.Color(0.9373, 0.9373, 0.9804)],
      [0.0118, new THREE.Color(0.9059, 0.9059, 0.9804)],
      Severity: Major
      Found in app/scripts/pointcloud/gradients.service.js and 1 other location - About 3 wks to fix
      app/scripts/pointcloud/gradients.service.js on lines 6..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 3600.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Potree.Gradients.VIRIDIS = [
      [0, new THREE.Color(0.267, 0.0049, 0.3294)],
      [0.0039, new THREE.Color(0.2685, 0.0096, 0.3354)],
      [0.0078, new THREE.Color(0.2699, 0.0146, 0.3414)],
      [0.0118, new THREE.Color(0.2713, 0.0199, 0.3473)],
      Severity: Major
      Found in app/scripts/pointcloud/gradients.service.js and 1 other location - About 3 wks to fix
      app/scripts/pointcloud/gradients.service.js on lines 265..522

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 3600.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status