Sign upLogin

NYULibraries/getit

View on GitHub
Star
app/assets/javascripts/resolve/stackmap.js

Summary

Maintainability
D
2 days
Test Coverage

Function StackMapZoomMap has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function StackMapZoomMap(o){
  var defaults = {
      boxHeight: 510,
      boxWidth: 680,
      container: jQuery('#SMmap-container'),
Severity: Major
Found in app/assets/javascripts/resolve/stackmap.js - About 4 hrs to fix

    Function buildPopup has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        buildPopup: function(popupId, result) {
      if(result.maps.length != 0) { //if it was successful...
        map = result.maps[0];
        var holdingTitle = jQuery('h2.title').eq(1).html();  // TODO
        var $popup = jQuery('<div>', {
    Severity: Major
    Found in app/assets/javascripts/resolve/stackmap.js - About 3 hrs to fix

      File stackmap.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*! Copyright (c) 2011 Brandon Aaron (http://brandonaaron.net)
 * Licensed under the MIT License (LICENSE.txt).
 *
 * Thanks to: http://adomas.org/javascript-mouse-wheel/ for some pointers.
 * Thanks to: Mathias Bank(http://www.mathias-bank.de) for a scope bug fix.
      Severity: Minor
      Found in app/assets/javascripts/resolve/stackmap.js - About 3 hrs to fix

        Function StackMapZoomMap has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        function StackMapZoomMap(o){
  var defaults = {
      boxHeight: 510,
      boxWidth: 680,
      container: jQuery('#SMmap-container'),
        Severity: Minor
        Found in app/assets/javascripts/resolve/stackmap.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function buildPopup has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            buildPopup: function(popupId, result) {
      if(result.maps.length != 0) { //if it was successful...
        map = result.maps[0];
        var holdingTitle = jQuery('h2.title').eq(1).html();  // TODO
        var $popup = jQuery('<div>', {
        Severity: Minor
        Found in app/assets/javascripts/resolve/stackmap.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addPopup has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            addPopup: function(mapLink) {
      var $mapLink = jQuery(mapLink);
      var mapId = $mapLink.data('id');
      var popupId = 'popup' + mapId;
      var library = trimHTML($mapLink.data('library'));
        Severity: Minor
        Found in app/assets/javascripts/resolve/stackmap.js - About 1 hr to fix

          Function addPopup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              addPopup: function(mapLink) {
      var $mapLink = jQuery(mapLink);
      var mapId = $mapLink.data('id');
      var popupId = 'popup' + mapId;
      var library = trimHTML($mapLink.data('library'));
          Severity: Minor
          Found in app/assets/javascripts/resolve/stackmap.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            m.container.find(m.zoomInBtn).click(function(){m.setZoomFactor(m.curZoomFactor * m.zoomFactor, m.halfBoxWidth, m.halfBoxHeight);});
          Severity: Major
          Found in app/assets/javascripts/resolve/stackmap.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/resolve/stackmap.js on lines 122..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            m.container.find(m.zoomOutBtn).click(function(){m.setZoomFactor(m.curZoomFactor / m.zoomFactor, m.halfBoxWidth, m.halfBoxHeight);});
          Severity: Major
          Found in app/assets/javascripts/resolve/stackmap.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/resolve/stackmap.js on lines 121..121

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                m.sizeYContents.each(function(){jQuery(this).height(Math.ceil(jQuery(this).attr('height') * m.curZoomFactor));});
          Severity: Major
          Found in app/assets/javascripts/resolve/stackmap.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/resolve/stackmap.js on lines 97..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                m.sizeXContents.each(function(){jQuery(this).width(Math.ceil(jQuery(this).attr('width') * m.curZoomFactor));});
          Severity: Major
          Found in app/assets/javascripts/resolve/stackmap.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/resolve/stackmap.js on lines 98..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status