Function StackMapZoomMap has 109 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function StackMapZoomMap(o){
  var defaults = {
      boxHeight: 510,
      boxWidth: 680,
      container: jQuery('#SMmap-container'),

Function buildPopup has 82 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    buildPopup: function(popupId, result) {
      if(result.maps.length != 0) { //if it was successful...
        map = result.maps[0];
        var holdingTitle = jQuery('h2.title').eq(1).html();  // TODO
        var $popup = jQuery('<div>', {

File stackmap.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*! Copyright (c) 2011 Brandon Aaron (http://brandonaaron.net)
 * Licensed under the MIT License (LICENSE.txt).
 *
 * Thanks to: http://adomas.org/javascript-mouse-wheel/ for some pointers.
 * Thanks to: Mathias Bank(http://www.mathias-bank.de) for a scope bug fix.

Function StackMapZoomMap has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.

Open

function StackMapZoomMap(o){
  var defaults = {
      boxHeight: 510,
      boxWidth: 680,
      container: jQuery('#SMmap-container'),

• Read up
  Read up

Method handle has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

  def handle(request)
    if(request.get_service_type("wayfinder", { :refresh => true }).empty?)
      rfr_id = request.referrer_id
      unless(rfr_id.nil?)
        @known_rfrs.each do |known_rfr|

• Read up
  Read up

Method create has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

  def create
    if authorizer.present?
      # Is this a valid request type?
      valid_type = whitelist_type(params[:type])
      if valid_type

• Read up
  Read up

Class HoldingRequestsController has 23 methods (exceeds 20 allowed). Consider refactoring.

Open

class HoldingRequestsController < UmlautController
  # For now, a constant for the ILLiad URL
  ILLIAD_BASE_URL = (ENV['ILLIAD_BASE_URL'] || 'http://ill.library.nyu.edu')

  # E-ZBorrow URL

Method _search_by_title has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      def _search_by_title(query, search_type, page=1)
        query = query.upcase
        [/^THE /, /^AN? /].each do |article|
          query.gsub! article, ""
        end

Function buildPopup has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.

Open

    buildPopup: function(popupId, result) {
      if(result.maps.length != 0) { //if it was successful...
        map = result.maps[0];
        var holdingTitle = jQuery('h2.title').eq(1).html();  // TODO
        var $popup = jQuery('<div>', {

• Read up
  Read up

Method url_for has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

  def url_for(options={})
    if institution_param.present?
      if options.is_a?(Hash)
        options[institution_param_name] ||= institution_param
      elsif options.is_a?(String)

• Read up
  Read up

Function addPopup has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    addPopup: function(mapLink) {
      var $mapLink = jQuery(mapLink);
      var mapId = $mapLink.data('id');
      var popupId = 'popup' + mapId;
      var library = trimHTML($mapLink.data('library'));

Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    def initialize(service_response)
      unless service_response.is_a?(ServiceResponse)
        raise ArgumentError.new("Expecting #{service_response} to be a ServiceResponse")
      end
      unless VALID_SERVICE_IDS.include? service_response.service_id

• Read up
  Read up

Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def create
    if authorizer.present?
      # Is this a valid request type?
      valid_type = whitelist_type(params[:type])
      if valid_type

Avoid deeply nested control flow statements.

Open

            unless create_hold.error?
              # Create the holding request for the current user
              redirect_to(holding_request_path(service_response, entire: entire, pickup_location: pickup_location.code))
            else
              flash[:alert] = create_hold.note

Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def initialize(service_response)
        super(service_response)
        unless VALID_SOURCES.include? view_data[:source_id]
          raise ArgumentError.new("Expecting #{view_data} to have a valid :source_id")
        end

• Read up
  Read up

Method _to_context_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def _to_context_object(hit, context_object)
        ctx = OpenURL::ContextObject.new
        # Start out wtih everything in search, to preserve date/vol/etc
        ctx.import_context_object(context_object)
        # Put SFX object id in rft.object_id, that's what SFX does.

• Read up
  Read up

Method pickup_locations_field_set has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

  def pickup_locations_field_set(field_set_options=nil)
    field_set_tag(nil, field_set_options) do
      if pickup_locations.size > 1
        label_tag('pickup_location', 'Select pickup location:') +
         select_tag('pickup_location', options_for_select(pickup_locations.to_a))

• Read up
  Read up

Method institutions_in_play has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  def institutions_in_play(requested_institution)
    institutions_in_play = []
    # Always add default institutions
    institutions_in_play += Institutions.defaults
    # Remove NYU at the start

• Read up
  Read up

Method destroy_successful_nyu_primo_source_dispatched_services has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  def destroy_successful_nyu_primo_source_dispatched_services(request)
    # Only do this after all services have finished.
    unless request.any_services_in_progress?
      nyu_primo_source_dispatched_services =
        request.dispatched_services.where(service_id: 'NYU_Primo_Source')

• Read up
  Read up

Method expire_or_destroy_nyu_primo_source_service_responses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

  def expire_or_destroy_nyu_primo_source_service_responses(request)
    # Only do this after all services have finished.
    unless request.any_services_in_progress?
      nyu_primo_source_service_responses =
        request.service_responses.where(service_id: 'NYU_Primo_Source')

• Read up
  Read up