Sign upLogin

NYULibraries/nyulibraries-assets

View on GitHub
Star

Showing 4 of 4 total issues

Method dropdown has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def dropdown(title, list, toggle_button = true, html_options = {:class => "dropdown"}, toggle_html_options = {class: "dropdown-toggle"}, menu_html_options={class: "dropdown-menu"})
Severity: Minor
Found in app/helpers/nyulibraries/assets/html_helper.rb - About 45 mins to fix

    Method reload_ip_addresses_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def reload_ip_addresses_for(institution)
        institution_ip_addresses = []
        Institutions.loadfiles.each do |loadfile|
          # Loop through institutions in the yaml
          YAML.load(ERB.new(File.read(loadfile)).result).each_pair do |code, elements|
    Severity: Minor
    Found in app/helpers/nyulibraries/assets/institutions_helper.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tooltip_tag has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def tooltip_tag content, title, url = "#", placement = "right", css_classes = "help-inline record-help"
    Severity: Minor
    Found in app/helpers/nyulibraries/assets/html_helper.rb - About 35 mins to fix

      Method url_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def url_for(options={})
        if institution_param.present? and options.is_a? Hash
          options[institution_param_name] ||= institution_param
        end
        if institute_param.present? and options.is_a? Hash
      Severity: Minor
      Found in app/helpers/nyulibraries/assets/institutions_helper.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language