Sign upLogin

Nanocloud/nanocloud

View on GitHub
Star
api/controllers/AppController.js

Summary

Maintainability
D
2 days
Test Coverage

Function connections has 155 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  connections(req, res) {

    var connections = [];
    var getImagesPromise = null;
Severity: Major
Found in api/controllers/AppController.js - About 6 hrs to fix

    File AppController.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Nanocloud turns any traditional software into a cloud solution, without
 * changing or redeveloping existing source code.
 *
 * Copyright (C) 2016 Nanocloud Software
    Severity: Minor
    Found in api/controllers/AppController.js - About 3 hrs to fix

      Function update has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        update(req, res) {

    let applicationData = JsonApiService.deserialize(req.body.data);
    let attributes = applicationData.attributes;
      Severity: Major
      Found in api/controllers/AppController.js - About 2 hrs to fix

        Function _getApps has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _getApps(user) {

    return new Promise((resolve, reject) => {
      return App.query({
        text: `SELECT DISTINCT
        Severity: Minor
        Found in api/controllers/AppController.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (req.user.isAdmin) {
      App.findOne({
        id: req.allParams().id
      })
        .populate('image')
          Severity: Major
          Found in api/controllers/AppController.js and 1 other location - About 4 hrs to fix
          api/controllers/ImageController.js on lines 105..123

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _getApps(user) {

    return new Promise((resolve, reject) => {
      return App.query({
        text: `SELECT DISTINCT
          Severity: Major
          Found in api/controllers/AppController.js and 1 other location - About 2 hrs to fix
          api/controllers/ImageController.js on lines 39..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 92.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                App.findOne({
        id: req.allParams().id
      })
        .populate('image')
        .populate('groups')
          Severity: Minor
          Found in api/controllers/AppController.js and 1 other location - About 55 mins to fix
          api/controllers/ImageController.js on lines 106..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status