Sign upLogin

Nanocloud/nanocloud

View on GitHub
Star
api/controllers/ImageController.js

Summary

Maintainability
C
1 day
Test Coverage

Function find has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  find: function(req, res) {

    this._getImages(req.user)
      .then((images) => {
        let imageIds = _.map(images.rows, 'id');
Severity: Minor
Found in api/controllers/ImageController.js - About 1 hr to fix

    Function destroy has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      destroy: function(req, res) {
    var imageId = req.allParams().id;
    return Image.findOne({ id: imageId })
      .then((image) => {
        return MachineService.deleteImage(image);
    Severity: Minor
    Found in api/controllers/ImageController.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (req.user.isAdmin) {
      Image.findOne({
        id: req.allParams().id
      })
        .populate('apps')
      Severity: Major
      Found in api/controllers/ImageController.js and 1 other location - About 4 hrs to fix
      api/controllers/AppController.js on lines 90..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        _getImages(user) {

    return new Promise((resolve, reject) => {
      return Image.query({
        text: `SELECT DISTINCT
      Severity: Major
      Found in api/controllers/ImageController.js and 1 other location - About 2 hrs to fix
      api/controllers/AppController.js on lines 43..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            Image.findOne({
        id: req.allParams().id
      })
        .populate('apps')
        .populate('groups')
      Severity: Minor
      Found in api/controllers/ImageController.js and 1 other location - About 55 mins to fix
      api/controllers/AppController.js on lines 91..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status