Sign upLogin

Nanocloud/nanocloud

View on GitHub
Star
api/controllers/StorageController.js

Summary

Maintainability
F
4 days
Test Coverage

Function upload has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  upload: function(req, res) {
    let user = req.user;
    let filename = req.query.filename;
    let promise = null;
Severity: Minor
Found in api/controllers/StorageController.js - About 1 hr to fix

    Function files has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      files: function(req, res) {

    let getFiles;
    let machine = req.allParams().machine;
    Severity: Minor
    Found in api/controllers/StorageController.js - About 1 hr to fix

      Function download has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        download: function(req, res) {
    let filename = req.query.filename;
    let downloadToken = req.query.token;

    AccessToken.findOne({
      Severity: Minor
      Found in api/controllers/StorageController.js - About 1 hr to fix

        Function rename has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          rename: function(req, res) {
    let filename = req.query.filename;
    let newFilename = req.query.newfilename;
    let promise = null;
        Severity: Minor
        Found in api/controllers/StorageController.js - About 1 hr to fix

          Function create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            create: function(req, res) {
    let filename = req.query.filename;
    let promise = null;

    if (req.allParams().teams === 'true') {
          Severity: Minor
          Found in api/controllers/StorageController.js - About 1 hr to fix

            Function destroy has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              destroy: function(req, res) {
    let filename = req.query.filename;
    let promise = null;

    if (req.allParams().teams === 'true') {
            Severity: Minor
            Found in api/controllers/StorageController.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                destroy: function(req, res) {
    let filename = req.query.filename;
    let promise = null;

    if (req.allParams().teams === 'true') {
              Severity: Major
              Found in api/controllers/StorageController.js and 1 other location - About 1 day to fix
              api/controllers/StorageController.js on lines 44..73

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 277.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                create: function(req, res) {
    let filename = req.query.filename;
    let promise = null;

    if (req.allParams().teams === 'true') {
              Severity: Major
              Found in api/controllers/StorageController.js and 1 other location - About 1 day to fix
              api/controllers/StorageController.js on lines 81..110

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 277.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status