Sign upLogin

NatLibFi/marc-record-converters

View on GitHub
Star
lib/converters/iso2709.js

Summary

Maintainability
F
4 days
Test Coverage

Function factory has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
Open

function factory(MarcRecord, xmldom)
{


  /**
Severity: Minor
Found in lib/converters/iso2709.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 223 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(MarcRecord, xmldom)
{


  /**
Severity: Major
Found in lib/converters/iso2709.js - About 1 day to fix

    Function convertFromISO2709 has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function convertFromISO2709(record_data)
  {

    function convertRecord(record_str)
    {
    Severity: Major
    Found in lib/converters/iso2709.js - About 2 hrs to fix

      Function convertRecord has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function convertRecord(record_str)
    {
      
      /**
       * Parse directory section
      Severity: Major
      Found in lib/converters/iso2709.js - About 2 hrs to fix

        Function processDirectoryEntry has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              function processDirectoryEntry(entry)
      {
        
        var field_element_str, data_element_str, datafield;      
        var tag = dirFieldTag(entry),
        Severity: Major
        Found in lib/converters/iso2709.js - About 2 hrs to fix

          Function convertToISO2709 has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function convertToISO2709(record_data)
  {

    function convertRecord(record)
    {
          Severity: Minor
          Found in lib/converters/iso2709.js - About 1 hr to fix

            Function convertRecord has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function convertRecord(record)
    {
    
    var record_str = '',
        directory_str = '',
            Severity: Minor
            Found in lib/converters/iso2709.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              (function(root, factory) {

  'use strict';

  if (typeof define === 'function' && define.amd) {
              Severity: Major
              Found in lib/converters/iso2709.js and 1 other location - About 2 hrs to fix
              lib/converters/aleph-sequential.js on lines 29..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status