Sign upLogin

NatLibFi/marc-record-converters

View on GitHub
Star
lib/converters/marc21slim-xml.js

Summary

Maintainability
D
2 days
Test Coverage

Function factory has 162 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(MarcRecord, xmldom)
{

  'use strict';
Severity: Major
Found in lib/converters/marc21slim-xml.js - About 6 hrs to fix

    Function factory has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

    function factory(MarcRecord, xmldom)
{

  'use strict';
    Severity: Minor
    Found in lib/converters/marc21slim-xml.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function convertFromXML has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function convertFromXML(str)
  {

    function getRecords(offset, records)
    {
    Severity: Major
    Found in lib/converters/marc21slim-xml.js - About 3 hrs to fix

      Function getRecords has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function getRecords(offset, records)
    {

      function notTextNode(node) {
        return node.nodeType !== NODE_TYPE.text_node;
      Severity: Major
      Found in lib/converters/marc21slim-xml.js - About 3 hrs to fix

        Function convertToXML has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function convertToXML(record_data)
  {

    function mkDatafield(field) {
        Severity: Major
        Found in lib/converters/marc21slim-xml.js - About 2 hrs to fix

          There are no issues that match your filters.

          Category
          Status