Sign upLogin

NatLibFi/marc-record-serializers

View on GitHub
Star
src/marcxml.js

Summary

Maintainability
C
1 day
Test Coverage

Function reader has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function reader (stream, validationOptions = {}, nameSpace = '') {
  const emitter = new class extends EventEmitter { }();
  const nameSpacePrefix = nameSpace === '' ? nameSpace : `${nameSpace}:`;

  MarcRecord.setValidationOptions(validationOptions);
Severity: Minor
Found in src/marcxml.js - About 1 hr to fix

    Function to has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    export function to(record, {omitDeclaration = false, indent = false} = {}) {
  const obj = {
    record: {
      ...generateFields(),
      $: {
    Severity: Minor
    Found in src/marcxml.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function from has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function from(str, validationOptions = {}) {
  const record = new MarcRecord(undefined, validationOptions);
  const obj = await toObject();

  // eslint-disable-next-line functional/immutable-data
    Severity: Minor
    Found in src/marcxml.js - About 1 hr to fix

      Function start has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function start() {
    // eslint-disable-next-line functional/no-let
    let charbuffer = '';

    stream.on('end', () => {
      Severity: Minor
      Found in src/marcxml.js - About 1 hr to fix

        Function generateFields has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function generateFields() {
    return {
      leader: [record.leader],
      controlfield: record.getControlfields().map(({value: _, tag}) => {
        if (_) {
        Severity: Minor
        Found in src/marcxml.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                controlfield: record.getControlfields().map(({value: _, tag}) => {
        if (_) {
          return {_, $: {tag: [tag]}};
        }
          Severity: Major
          Found in src/marcxml.js and 1 other location - About 1 hr to fix
          src/marcxml.js on lines 124..130

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  return subfields.map(({code, value: _}) => {
          if (_) {
            return {_, $: {code: [code]}};
          }
          Severity: Major
          Found in src/marcxml.js and 1 other location - About 1 hr to fix
          src/marcxml.js on lines 103..109

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status