Sign upLogin

NatLibFi/marc-record-validators-melinda

View on GitHub
Star
src/addMissingField336.js

Summary

Maintainability
F
5 days
Test Coverage

Function default has a Cognitive Complexity of 104 (exceeds 5 allowed). Consider refactoring.
Open

export default function () {

  return {
    description, validate, fix
  };
Severity: Minor
Found in src/addMissingField336.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function default has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function () {

  return {
    description, validate, fix
  };
Severity: Major
Found in src/addMissingField336.js - About 6 hrs to fix

    Function guessMissingBsForComputerFile has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function guessMissingBsForComputerFile(record) {
    const [field008] = record.get('008');
    const typeOfComputerFile = field008 && field008.value ? field008.value[26] : undefined;

    if (typeOfComputerFile) {
    Severity: Major
    Found in src/addMissingField336.js - About 2 hrs to fix

      Function guessMissing336Bs has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function guessMissing336Bs(record) {
    const typeOfRecord = record.getTypeOfRecord();

    if (typeOfRecord === 'i') {
      return ['spw'];
      Severity: Minor
      Found in src/addMissingField336.js - About 1 hr to fix

        Function guessUsingFileFields has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function guessUsingFileFields() {
      const characteristics = record.get('(256|516)').map(f => fieldToString(f));
      if (characteristics.some(str => str.match(/(?:ohjelma)/gui))) {
        return ['cop'];
      }
        Severity: Minor
        Found in src/addMissingField336.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return undefined;
          Severity: Major
          Found in src/addMissingField336.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return ['zzz']; // unspecified
            Severity: Major
            Found in src/addMissingField336.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return ['tdi']; // 2d moving pic
              Severity: Major
              Found in src/addMissingField336.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return guessMissingBsForBookAndContinuingResource(record, formOfItem);
                Severity: Major
                Found in src/addMissingField336.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return ['tdf'];
                  Severity: Major
                  Found in src/addMissingField336.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return guess;
                    Severity: Major
                    Found in src/addMissingField336.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return ['tcm']; // tactile notated music
                      Severity: Major
                      Found in src/addMissingField336.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return ['sti'];
                        Severity: Major
                        Found in src/addMissingField336.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return ['txt'];
                          Severity: Major
                          Found in src/addMissingField336.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return ['txt'];
                            Severity: Major
                            Found in src/addMissingField336.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return ['tdi'];
                              Severity: Major
                              Found in src/addMissingField336.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return ['cri']; // cri or crd, close enough anyhow, I guess
                                Severity: Major
                                Found in src/addMissingField336.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return ['sti']; // still image
                                  Severity: Major
                                  Found in src/addMissingField336.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                        return ['zzz']; // unspecified
                                    Severity: Major
                                    Found in src/addMissingField336.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                            return ['xxx']; // other
                                      Severity: Major
                                      Found in src/addMissingField336.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                                return ['tdi'];
                                        Severity: Major
                                        Found in src/addMissingField336.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                  return ['tdi', 'cop'];
                                          Severity: Major
                                          Found in src/addMissingField336.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                  return guessMissingBsForComputerFile(record);
                                            Severity: Major
                                            Found in src/addMissingField336.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                      return ['cod'];
                                              Severity: Major
                                              Found in src/addMissingField336.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                      return ['xxx'];
                                                Severity: Major
                                                Found in src/addMissingField336.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                          return ['snd'];
                                                  Severity: Major
                                                  Found in src/addMissingField336.js - About 30 mins to fix

                                                    Avoid too many return statements within this function.
                                                    Open

                                                          return ['ntm']; // notated music
                                                    Severity: Major
                                                    Found in src/addMissingField336.js - About 30 mins to fix

                                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                                      Open

                                                          const data = {tag: '336', ind1: ' ', ind2: ' ', subfields: [
      {code: 'a', value: a},
      {code: 'b', value: b},
      {code: '2', value: 'rdacontent'}
    ]};
                                                      Severity: Major
                                                      Found in src/addMissingField336.js and 1 other location - About 1 hr to fix
                                                      src/addMissingField337.js on lines 114..118

                                                      Duplicated Code

                                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                      Tuning

                                                      This issue has a mass of 65.

                                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                      Refactorings

                                                      Further Reading

                                                      There are no issues that match your filters.

                                                      Category
                                                      Status