NatLibFi/marc-record-validators-melinda

File ending-punctuation.spec.js has 2265 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import chai from 'chai';
import chaiAsPromised from 'chai-as-promised';
import {MarcRecord} from '@natlibfi/marc-record';
import validatorFactory from '../src/ending-punctuation';

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const recordBroken = new MarcRecord({
      leader: '',
      fields: [
        {
          tag: '245',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const recordInvalid = new MarcRecord({
      leader: '',
      fields: [
        {
          tag: '245',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordValidComplex = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '340',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordInvalidComplexDMissing = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '340',

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $b', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid);
        expect(recordInvalid.equalsTo(recordValid)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $b', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidSimple);
        expect(recordInvalidSimple.equalsTo(recordValidSimple)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (only)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidA);
        expect(recordInvalidA.equalsTo(recordInvalidA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (only)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid);
        expect(recordInvalid.equalsTo(recordValid)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (only)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid);
        expect(recordInvalid.equalsTo(recordValid)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $i (last)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidMissingI);
        expect(recordInvalidMissingI.equalsTo(recordValid)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Remove punc $e (language field, strict)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid);
        expect(recordInvalid.equalsTo(recordValid)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 647 Fast, removes double punc $d', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid647FastEndPunc);
        expect(recordInvalid647FastEndPunc.equalsTo(recordValid647FastEndPunc)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('Repairs the invalid record', async () => {
      const validator = await validatorFactory();
      const result = await validator.fix(recordBroken);
      expect(recordBroken.equalsTo(recordValid)).to.eql(true);
      expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidOnlyAMissingA);
        expect(recordInvalidOnlyAMissingA.equalsTo(recordValidOnlyA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $c', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidEndC);
        expect(recordInvalidEndC.equalsTo(recordValidEndC)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $c', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidInd2v1);
        expect(recordInvalidInd2v1.equalsTo(recordValidInd2v1)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 655 Finnish, remove punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid655FinYes);
        expect(recordInvalid655FinYes.equalsTo(recordValid655FinNo)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a & remove punc $y (Language field)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidOnlyAMissingAPuncY);
        expect(recordInvalidOnlyAMissingAPuncY.equalsTo(recordValidOnlyA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (last before $u)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidWithU);
        expect(recordInvalidWithU.equalsTo(recordValidWithU)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 648 Fast, removes punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid648FastYes);
        expect(recordInvalid648FastYes.equalsTo(recordValid648FastNo)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 655 Finnish, removes punc $a 2', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid655FinYes2);
        expect(recordInvalid655FinYes2.equalsTo(recordValid655FinNo2)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $d (last of list)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidComplexDMissing);
        expect(recordInvalidComplexDMissing.equalsTo(recordInvalidComplexDMissing)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 655 !Finnish, add punc $a (no control)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid655EngNoNoControl);
        expect(recordInvalid655EngNoNoControl.equalsTo(recordValid655EngYesNoControl)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $d (last of two)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidDDMissing);
        expect(recordInvalidDDMissing.equalsTo(recordValidDD)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Removes punc $a (register)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidOnlyA);
        expect(recordInvalidOnlyA.equalsTo(recordValidOnlyA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Remove punc $b (only data field)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidWithoutA);
        expect(recordInvalidWithoutA.equalsTo(recordValidWithoutA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordValidWithoutYMissingA);
        expect(recordValidWithoutYMissingA.equalsTo(recordValidWithoutY)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Remove double punc $g', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidEndGDouble);
        expect(recordInvalidEndGDouble.equalsTo(recordValidEndG)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (last)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidAMissingB);
        expect(recordInvalidAMissingB.equalsTo(recordValidAB)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 650 Finnish, removes punc $x', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid650FinYes);
        expect(recordInvalid650FinYes.equalsTo(recordValid650FinNo)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 650 !Finnish, add punc $v (no control)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid650EngNoControl);
        expect(recordInvalid650EngNoControl.equalsTo(recordValid650EngNoControl)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 656 Finnish, remove punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid656FinYes);
        expect(recordInvalid656FinYes.equalsTo(recordValid656FinNo)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 658 !Finnish, add punc $d', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid658EngNo);
        expect(recordInvalid658EngNo.equalsTo(recordValid658EngYes)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Remove punc $y (Language field)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidOnlyAPuncY);
        expect(recordInvalidOnlyAPuncY.equalsTo(recordValidOnlyA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 650 !Finnish, add punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid650EngControl);
        expect(recordInvalid650EngControl.equalsTo(recordValid650EngControl)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 655 !Finnish, add punc $y', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid655EngNo);
        expect(recordInvalid655EngNo.equalsTo(recordValid655EngYes)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 657 !Finnish, add punc $z', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid657EngNo);
        expect(recordInvalid657EngNo.equalsTo(recordValid657EngYes)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (only)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidOnlyA);
        expect(recordInvalidOnlyA.equalsTo(recordValidOnlyA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Remove punc $c ($c has ©, should not have punc)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidCopyrightCExtra);
        expect(recordInvalidCopyrightCExtra.equalsTo(recordValidCopyright)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 662 !Finnish, add pun $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalid662EngNo);
        expect(recordInvalid662EngNo.equalsTo(recordValid662EngYes)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $b (mandatory)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidABMissing);
        expect(recordInvalidABMissing.equalsTo(recordValidAB)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $p', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordValidMultipleMissingP);
        expect(recordValidMultipleMissingP.equalsTo(recordValidMultiple)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $a (only)', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidOnlyA);
        expect(recordInvalidOnlyA.equalsTo(recordValidOnlyA)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - Add punc $c', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvalidComplex);
        expect(recordInvalidComplex.equalsTo(recordValidComplex)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 27 locations. Consider refactoring.

Open

      it('Repairs the invalid record - 648 Finnish, removes punc $a', async () => {
        const validator = await validatorFactory();
        const result = await validator.fix(recordInvali648dFinYes);
        expect(recordInvali648dFinYes.equalsTo(recordVali648dFinNo)).to.eql(true);
        expect(result).to.eql({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordValidComplex = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '880',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordInvalidComplex = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '880',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordValidMultiple = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '242',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordValidMultipleMissingP = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '242',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      const recordInvalidEndGDouble = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '260',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      const recordInvalid657EngNo = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '657',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      const recordValidEndG = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '260',

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      const recordValid657EngYes = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '657',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordValidSimple = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '880',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordInvalidSimple = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '880',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordValidEndC = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '260',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordValid = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '760',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordInvalid = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '760',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordInvalid647FastEndPunc = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '647',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordInvalidMissingI = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '538',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordInvalidEndC = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '260',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordValidInd2v1 = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '264',

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

      const recordValid647FastEndPunc = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '647',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordValid = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '538',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const recordInvalidI = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '538',

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      const recordValidInd2v1Short = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '264',

• Read up
  Read up

Similar blocks of code found in 12 locations. Consider refactoring.

Open

      const recordValid658EngYes = new MarcRecord({
        leader: '',
        fields: [
          {
            tag: '658',

• Read up
  Read up