Sign upLogin

NatLibFi/marc-record-validators-melinda

View on GitHub
Star
src/field-008-18-34-character-groups.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function processCharacterGroup has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function processCharacterGroup(field, group) {
  const originalContent = field.value.substring(group.start, group.end + 1);
  const content = removeDuplicateValues(fixBlanks(originalContent));
  //console.info(`008/${group.start}-${group.end}: '${originalContent}'`); // eslint-disable-line no-console
  const charArray = content.split('');
Severity: Minor
Found in src/field-008-18-34-character-groups.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function default has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function () {

  return {
    description: 'Justify left and sort character groups within 008/18-24',
    validate, fix
Severity: Minor
Found in src/field-008-18-34-character-groups.js - About 1 hr to fix

    Function processCharacterGroup has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function processCharacterGroup(field, group) {
  const originalContent = field.value.substring(group.start, group.end + 1);
  const content = removeDuplicateValues(fixBlanks(originalContent));
  //console.info(`008/${group.start}-${group.end}: '${originalContent}'`); // eslint-disable-line no-console
  const charArray = content.split('');
    Severity: Minor
    Found in src/field-008-18-34-character-groups.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return asciiCode + 200;
      Severity: Major
      Found in src/field-008-18-34-character-groups.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status