Sign upLogin

NatLibFi/marc-record-validators-melinda

View on GitHub
Star
src/fix-33X.js

Summary

Maintainability
D
2 days
Test Coverage

File fix-33X.js has 442 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//import createDebugLogger from 'debug';
import clone from 'clone';
import {fieldToString, getCatalogingLanguage, nvdebug} from './utils';
import {map336CodeToTerm, map337CodeToTerm, map338CodeToTerm} from './field33XUtils';
Severity: Minor
Found in src/fix-33X.js - About 6 hrs to fix

    Function default has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function () {

  return {
    description, validate, fix
  };
    Severity: Minor
    Found in src/fix-33X.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function default has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function () {

  return {
    description, validate, fix
  };
    Severity: Major
    Found in src/fix-33X.js - About 3 hrs to fix

      Function fixField has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function fixField(field, catalogingLanguage = 'fin') {
    const subfieldA = getA(field);
    if (!subfieldA) {
      return;
    }
      Severity: Minor
      Found in src/fix-33X.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status