Sign upLogin

NatLibFi/marc-record-validators-melinda

View on GitHub
Star
src/mergeField500Lisapainokset.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function extractAllPrintData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function extractAllPrintData(relevantFields) {
  /* eslint-disable */
  // Gather data about 500 $a Lisäpainokset.*
  let allPrintData = [];
  let i;
Severity: Minor
Found in src/mergeField500Lisapainokset.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mergePrintData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function mergePrintData(value1, value2) {
  const [index1, print1, year1] = value1.split(' ');
  const [index2, print2, year2] = value2.split(' ');

  const betterIndex = index1 ? index1 : index2; // just to cheat eslint...
Severity: Minor
Found in src/mergeField500Lisapainokset.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function mergePrintData has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function mergePrintData(value1, value2) {
  const [index1, print1, year1] = value1.split(' ');
  const [index2, print2, year2] = value2.split(' ');

  const betterIndex = index1 ? index1 : index2; // just to cheat eslint...
Severity: Minor
Found in src/mergeField500Lisapainokset.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

              if (!mergedPrintData) {
            return []; // reason for for-loops: exit function from within nested loops
          }
    Severity: Major
    Found in src/mergeField500Lisapainokset.js - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status