Sign upLogin

NatLibFi/marc-record-validators-melinda

View on GitHub
Star
src/punctuation2.js

Summary

Maintainability
C
7 hrs
Test Coverage

File punctuation2.js has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
* punctuation.js -- try and fix a marc field punctuation
*
* Author(s): Nicholas Volk <nicholas.volk@helsinki.fi>
*
Severity: Minor
Found in src/punctuation2.js - About 5 hrs to fix

    Function applyPunctuationRules has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function applyPunctuationRules(field, subfield1, subfield2, ruleArray = null, operation = NONE) {
    Severity: Minor
    Found in src/punctuation2.js - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

        return true;
      Severity: Major
      Found in src/punctuation2.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in src/punctuation2.js - About 30 mins to fix

          Function ruleAppliesToNextSubfield has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function ruleAppliesToNextSubfield(rule, nextSubfield) {
  if (!('followedBy' in rule)) { // Return true, if we are not interested in the next subfield
    return true;
  }
  // The '#' existence check applies only to the RHS field. LHS always exists.
          Severity: Minor
          Found in src/punctuation2.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status