Sign upLogin

NatLibFi/melinda-api-client

View on GitHub
Star
lib/index.js

Summary

Maintainability
D
1 day
Test Coverage

Function constructor has 186 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function constructor(config) {

    marc_record.MarcRecord.setValidationOptions({subfieldValues: false});

    function loadRecord(id, params, raw) {
Severity: Major
Found in lib/index.js - About 7 hrs to fix

    Function parseResponse has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function parseResponse(response) {
      var parser = new xmldom.DOMParser();
      var doc = parser.parseFromString(response);

      var messages = textContents(doc.getElementsByTagName('message')).map(parseMessage);
    Severity: Major
    Found in lib/index.js - About 2 hrs to fix

      Function loadChildRecords has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function loadChildRecords(id, params, raw) {

      var defer = Q.defer();
      raw = raw || false;
      Severity: Minor
      Found in lib/index.js - About 1 hr to fix

        Function updateRecord has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function updateRecord(record, params) {
      var defer = Q.defer();

      var idFields = record.fields.filter(function (f) {return f.tag == "001";});
      if (idFields.length !== 1 || isNaN(idFields[0].value)) {
        Severity: Minor
        Found in lib/index.js - About 1 hr to fix

          Function createRecord has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function createRecord(record, params) {
      var defer = Q.defer();

      record.fields = record.fields.filter(function (f) {
        return f.tag !== "001";
          Severity: Minor
          Found in lib/index.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    var opts = {
          headers: {
            "Content-Type": "text/xml",
            "Authorization": "Basic " + btoa(config.user + ":" + config.password)
          },
            Severity: Minor
            Found in lib/index.js and 1 other location - About 55 mins to fix
            lib/index.js on lines 189..195

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    var opts = {
          headers: {
            "Content-Type": "text/xml",
            "Authorization": "Basic " + btoa(config.user + ":" + config.password)
          },
            Severity: Minor
            Found in lib/index.js and 1 other location - About 55 mins to fix
            lib/index.js on lines 149..155

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      if (parsedResponse.errors.length === 0) {
            defer.resolve(parsedResponse);
          } else {
            defer.reject(parsedResponse);
          }
            Severity: Minor
            Found in lib/index.js and 1 other location - About 30 mins to fix
            lib/index.js on lines 199..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                      if (parsedResponse.errors.length === 0) {
            defer.resolve(parsedResponse);
          } else {
            defer.reject(parsedResponse);
          }
            Severity: Minor
            Found in lib/index.js and 1 other location - About 30 mins to fix
            lib/index.js on lines 160..164

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status