Sign upLogin

NateFerrero/amna

View on GitHub
Star
src/lib/collection.js

Summary

Maintainability
F
4 days
Test Coverage

Function exports has 258 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (amna) {

    amna.mongoId = function (param) {
        return ':' + param + '([0-9a-f]{24})';
    };
Severity: Major
Found in src/lib/collection.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (amna) {

    amna.mongoId = function (param) {
        return ':' + param + '([0-9a-f]{24})';
    };
    Severity: Minor
    Found in src/lib/collection.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File collection.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

/**
 * AMNA: Amazing Mongoose Node.js API
 *
    Severity: Minor
    Found in src/lib/collection.js - About 2 hrs to fix

      Function pageAndDeleteQuery has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          amna.pageAndDeleteQuery = function (self) {
        var query = {};
        var qOpts = self.req.jsonQueryOptions;

        /**
      Severity: Minor
      Found in src/lib/collection.js - About 1 hr to fix

        Function setupCollectionPost has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var setupCollectionPost = function (collection, options) {
        /**
         * POST /collection
         */
        if (!options.readOnly && options.collectionPost !== false) {
        Severity: Minor
        Found in src/lib/collection.js - About 1 hr to fix

          Function collectionPost has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      collection.routes.collectionPost = collection.collectionPost('', function (self) {
                var Model = collection.thing.model;

                var filter = function (data) {
                    /**
          Severity: Minor
          Found in src/lib/collection.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                var setupCollectionDelete = function (collection, options) {
        /**
         * DELETE /collection
         */
        if (!options.readOnly && options.collectionDelete !== false) {
            Severity: Major
            Found in src/lib/collection.js and 2 other locations - About 2 hrs to fix
            src/lib/collection.js on lines 194..203
            src/lib/collection.js on lines 227..236

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                var setupDocumentPost = function (collection, options) {
        /**
         * POST /collection/:id
         */
        if (!options.readOnly && options.documentPost !== false) {
            Severity: Major
            Found in src/lib/collection.js and 2 other locations - About 2 hrs to fix
            src/lib/collection.js on lines 194..203
            src/lib/collection.js on lines 205..214

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                var setupCollectionPut = function (collection, options) {
        /**
         * PUT /collection
         */
        if (!options.readOnly && options.collectionPut !== false) {
            Severity: Major
            Found in src/lib/collection.js and 2 other locations - About 2 hrs to fix
            src/lib/collection.js on lines 205..214
            src/lib/collection.js on lines 227..236

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (!self.permissionGranted &&
                    (!self.doc.createdBy || !self.req.user._id.equals(self.doc.createdBy))) {
                    return self.noaccess();
                }
            Severity: Major
            Found in src/lib/collection.js and 1 other location - About 2 hrs to fix
            src/lib/collection.js on lines 282..285

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (!self.permissionGranted &&
                    (!self.doc.createdBy || !self.req.user._id.equals(self.doc.createdBy))) {
                    return self.noaccess();
                }
            Severity: Major
            Found in src/lib/collection.js and 1 other location - About 2 hrs to fix
            src/lib/collection.js on lines 247..250

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            Object.keys(info.query).forEach(function (key) {
                    self.req.jsonQuery[key] = info.query[key];
                });
            Severity: Major
            Found in src/lib/collection.js and 1 other location - About 1 hr to fix
            src/lib/collection.js on lines 127..129

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            Object.keys(info.query).forEach(function (key) {
                    self.req.jsonQuery[key] = info.query[key];
                });
            Severity: Major
            Found in src/lib/collection.js and 1 other location - About 1 hr to fix
            src/lib/collection.js on lines 109..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status