Sign upLogin

NaturalIntelligence/fast-xml-parser

View on GitHub
Star
src/v5/Xml2JsParser.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function parseXml has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    parseXml() {
      //TODO: Separate TagValueParser as separate class. So no scope issue in node builder class 

      //OutputBuilder should be set in XML Parser
      this.outputBuilder = this.options.OutputBuilder.getInstance(this.options);
Severity: Minor
Found in src/v5/Xml2JsParser.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readSpecialTag has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    readSpecialTag(startCh){
      if(startCh == "!"){
        let nextChar = this.source.readCh();
        if (nextChar === null || nextChar === undefined) throw new Error("Unexpected ending of the source");
Severity: Minor
Found in src/v5/Xml2JsParser.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function resolveNameSpace has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function resolveNameSpace(name, removeNSPrefix) {
  if (removeNSPrefix) {
    const parts = name.split(':');
    if(parts.length === 2){
      if (parts[0] === 'xmlns') return '';
Severity: Minor
Found in src/v5/Xml2JsParser.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

            //TODO: shift parsing to output builder
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

TODO found
Open

        //TODO: pass tag name only to avoid string operations
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

TODO found
Open

      //TODO: return TagPath Object. User can call match method with path
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

TODO found
Open

      //TODO: Separate TagValueParser as separate class. So no scope issue in node builder class
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

TODO found
Open

        //TODO: this will lead 2 extra stack operation
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

TODO found
Open

        // TODO: let's user set a stop node boundary detector for complex contents like script tag
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

TODO found
Open

      //TODO: if option is set then replace entities
Severity: Minor
Found in src/v5/Xml2JsParser.js by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    parse(strData) {
        this.source = new StringSource(strData);
        this.parseXml();
        return this.outputBuilder.getOutput();
    }
Severity: Minor
Found in src/v5/Xml2JsParser.js and 1 other location - About 40 mins to fix
src/v5/Xml2JsParser.js on lines 38..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    parseBytesArr(data) {
        this.source = new BufferSource(data );
        this.parseXml();
        return this.outputBuilder.getOutput();
    }
Severity: Minor
Found in src/v5/Xml2JsParser.js and 1 other location - About 40 mins to fix
src/v5/Xml2JsParser.js on lines 33..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Parsing error: Unexpected token =
Open

    addTextNode = function() {
Severity: Minor
Found in src/v5/Xml2JsParser.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status