Sign upLogin

NodeBB/NodeBB

View on GitHub
Star

Showing 443 of 552 total issues

Function create has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

chatsAPI.create = async function (caller, data) {
    if (await rateLimitExceeded(caller, 'lastChatRoomCreateTime')) {
        throw new Error('[[error:too-many-messages]]');
    }
    if (!data) {
Severity: Minor
Found in src/api/chats.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updatePrivilges has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

async function updatePrivilges() {
    // if email confirmation is required
    //   give chat, posting privs to "verified-users" group
    //   remove chat, posting privs from "registered-users" group
Severity: Minor
Found in src/upgrades/1.15.0/verified_users_group.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function method has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    method: async function () {
        let configJSON;
        try {
            configJSON = require('../../../config.json') || { [process.env.database]: true, database: process.env.database };
        } catch (err) {
Severity: Minor
Found in src/upgrades/1.7.3/key_value_schema_change.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language