Showing 444 of 553 total issues
Function exports
has a Cognitive Complexity of 22 (exceeds 10 allowed). Consider refactoring. Open
module.exports = function (Posts) {
Posts.bookmark = async function (pid, uid) {
return await toggleBookmark('bookmark', pid, uid);
};
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has 106 lines of code (exceeds 75 allowed). Consider refactoring. Open
module.exports = function (Messaging) {
Messaging.setUserNotificationSetting = async (uid, roomId, value) => {
if (parseInt(value, 10) === -1) {
// go back to default
return await db.deleteObjectField(`chat:room:${roomId}:notification:settings`, uid);
Function init
has 105 lines of code (exceeds 75 allowed). Consider refactoring. Open
CategoryTools.init = function () {
topicSelect.init(updateDropdownOptions);
handlePinnedTopicSort();
Function exports
has 105 lines of code (exceeds 75 allowed). Consider refactoring. Open
module.exports = function (opts) {
const TTLCache = require('@isaacs/ttlcache');
const pubsub = require('../pubsub');
const ttlCache = new TTLCache(opts);
Function loadConfig
has 104 lines of code (exceeds 75 allowed). Consider refactoring. Open
apiController.loadConfig = async function (req) {
const config = {
relative_path,
upload_url,
asset_base_url,
Function exports
has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring. Open
module.exports = function (module) {
const helpers = require('../helpers');
module.sortedSetRemove = async function (key, value) {
if (!key) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring. Open
module.exports = function (User) {
User.follow = async function (uid, followuid) {
await toggleFollow('follow', uid, followuid);
};
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function exports
has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring. Open
module.exports = function (Posts) {
Posts.getPostsFromSet = async function (set, start, stop, uid, reverse) {
const pids = await Posts.getPidsFromSet(set, start, stop, reverse);
const posts = await Posts.getPostsByPids(pids, uid);
return await user.blocks.filter(uid, posts);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function checkSetupFlagEnv
has a Cognitive Complexity of 21 (exceeds 10 allowed). Consider refactoring. Open
function checkSetupFlagEnv() {
let setupVal = install.values;
const envConfMap = {
CONFIG: 'config',
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ajaxify.js
has 501 lines of code (exceeds 500 allowed). Consider refactoring. Open
'use strict';
const benchpress = require('benchpressjs');
const translator = require('./modules/translator');
const alerts = require('./modules/alerts');
Function init
has 100 lines of code (exceeds 75 allowed). Consider refactoring. Open
QuickReply.init = function () {
const element = components.get('topic/quickreply/text');
const qrDraftId = `qr:draft:tid:${ajaxify.data.tid}`;
const data = {
element: element,
Function init
has 100 lines of code (exceeds 75 allowed). Consider refactoring. Open
AdminsMods.init = function () {
autocomplete.user($('#admin-search'), function (ev, ui) {
socket.emit('admin.user.makeAdmins', [ui.item.user.uid], function (err) {
if (err) {
return alerts.error(err);
Function getTopic
has 99 lines of code (exceeds 75 allowed). Consider refactoring. Open
topicsController.get = async function getTopic(req, res, next) {
const tid = req.params.topic_id;
if (
(req.params.post_index && !utils.isNumber(req.params.post_index) && req.params.post_index !== 'unread') ||
!utils.isNumber(tid)
Function getUserDataByUserSlug
has 99 lines of code (exceeds 75 allowed). Consider refactoring. Open
helpers.getUserDataByUserSlug = async function (userslug, callerUID, query = {}) {
const uid = await user.getUidByUserslug(userslug);
if (!uid) {
return null;
}
Function fireStaticHook
has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring. Open
async function fireStaticHook(hook, hookList, params) {
if (!Array.isArray(hookList) || !hookList.length) {
return;
}
// don't bubble errors from these hooks, so bad plugins don't stop startup
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function search
has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring. Open
searchController.search = async function (req, res, next) {
if (!plugins.hooks.hasListeners('filter:search.query')) {
return next();
}
const page = Math.max(1, parseInt(req.query.page, 10)) || 1;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function merge
has 96 lines of code (exceeds 75 allowed). Consider refactoring. Open
Notifications.merge = async function (notifications) {
// When passed a set of notification objects, merge any that can be merged
const mergeIds = [
'notifications:upvoted-your-post-in',
'notifications:user-started-following-you',
Function email
has 95 lines of code (exceeds 75 allowed). Consider refactoring. Open
Interstitials.email = async (data) => {
if (!data.userData) {
throw new Error('[[error:invalid-data]]');
}
if (!data.userData.updateEmail) {
Function init
has 94 lines of code (exceeds 75 allowed). Consider refactoring. Open
userFilter.init = function (el, options) {
if (!el || !el.length) {
return;
}
options = options || {};
Function exports
has 94 lines of code (exceeds 75 allowed). Consider refactoring. Open
module.exports = function (module) {
const helpers = require('./helpers');
module.flushdb = async function () {
await module.client.send_command('flushdb', []);