Sign upLogin

NodeBB/NodeBB

View on GitHub
Star
src/controllers/category.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function get has a Cognitive Complexity of 26 (exceeds 10 allowed). Consider refactoring.
Open

categoryController.get = async function (req, res, next) {
    const cid = req.params.category_id;

    let currentPage = parseInt(req.query.page, 10) || 1;
    let topicIndex = utils.isNumber(req.params.topic_index) ? parseInt(req.params.topic_index, 10) - 1 : 0;
Severity: Minor
Found in src/controllers/category.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has 110 lines of code (exceeds 75 allowed). Consider refactoring.
Open

categoryController.get = async function (req, res, next) {
    const cid = req.params.category_id;

    let currentPage = parseInt(req.query.page, 10) || 1;
    let topicIndex = utils.isNumber(req.params.topic_index) ? parseInt(req.params.topic_index, 10) - 1 : 0;
Severity: Major
Found in src/controllers/category.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

            return next();
    Severity: Major
    Found in src/controllers/category.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return helpers.redirect(res, validator.unescape(categoryFields.link));
      Severity: Major
      Found in src/controllers/category.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return helpers.redirect(res, `/category/${categoryData.slug}/${categoryData.topic_count}?${qs.stringify(req.query)}`);
        Severity: Major
        Found in src/controllers/category.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return next();
          Severity: Major
          Found in src/controllers/category.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return helpers.redirect(res, `/category/${categoryFields.slug}?${qs.stringify(req.query)}`, true);
            Severity: Major
            Found in src/controllers/category.js - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status