Sign upLogin

NodeBB/NodeBB

View on GitHub
Star
src/emailer.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function send has a Cognitive Complexity of 15 (exceeds 10 allowed). Consider refactoring.
Open

Emailer.send = async (template, uid, params) => {
    if (!app) {
        throw Error('[emailer] App not ready!');
    }
Severity: Minor
Found in src/emailer.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setupFallbackTransport has a Cognitive Complexity of 13 (exceeds 10 allowed). Consider refactoring.
Open

Emailer.setupFallbackTransport = (config) => {
    winston.verbose('[emailer] Setting up fallback transport');
    // Enable SMTP transport if enabled in ACP
    if (parseInt(config['email:smtpTransport:enabled'], 10) === 1) {
        const smtpOptions = {
Severity: Minor
Found in src/emailer.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function sendToEmail has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

Emailer.sendToEmail = async (template, email, language, params) => {
    const lang = language || meta.config.defaultLang || 'en-GB';
    const unsubscribable = ['digest', 'notification'];

    // Digests and notifications can be one-click unsubbed
Severity: Minor
Found in src/emailer.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status