Sign upLogin

NodeBB/NodeBB

View on GitHub
Star
src/search.js

Summary

Maintainability
A
1 hr
Test Coverage

Consider simplifying this complex logical expression.
Open

    if (data.sortBy === 'relevance' &&
        !data.replies &&
        !data.timeRange &&
        !data.hasTags &&
        data.searchIn !== 'bookmarks' &&
Severity: Major
Found in src/search.js - About 40 mins to fix

    Function searchInContent has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    async function searchInContent(data) {
    data.uid = data.uid || 0;

    const [searchCids, searchUids] = await Promise.all([
        getSearchCids(data),
    Severity: Minor
    Found in src/search.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status