Sign upLogin

NodeBB/NodeBB

View on GitHub
Star
src/settings.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function get has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
Open

Settings.prototype.get = function (key, def) {
    let obj = this.cfg._;
    const parts = (key || '').split('.');
    let part;
    for (let i = 0; i < parts.length; i += 1) {
Severity: Minor
Found in src/settings.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Settings has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function Settings(hash, version, defCfg, callback, forceUpdate, reset) {
Severity: Minor
Found in src/settings.js - About 45 mins to fix

    Function expandObjBy has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
    Open

    function expandObjBy(obj1, obj2) {
    let changed = false;
    if (!obj1 || !obj2) {
        return changed;
    }
    Severity: Minor
    Found in src/settings.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function set has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
    Open

    Settings.prototype.set = function (key, val) {
    let part;
    let obj;
    let parts;
    this.cfg.v = this.version;
    Severity: Minor
    Found in src/settings.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status