Sign upLogin

NodeBB/NodeBB

View on GitHub
Star
src/topics/index.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function getTopicsByTids has 80 lines of code (exceeds 75 allowed). Consider refactoring.
Open

Topics.getTopicsByTids = async function (tids, options) {
    if (!Array.isArray(tids) || !tids.length) {
        return [];
    }
    let uid = options;
Severity: Major
Found in src/topics/index.js - About 1 hr to fix

    Function getTopicWithPosts has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    Topics.getTopicWithPosts = async function (topicData, set, uid, start, stop, reverse) {
    Severity: Minor
    Found in src/topics/index.js - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      Topics.exists = async function (tids) {
    return await db.exists(
        Array.isArray(tids) ? tids.map(tid => `topic:${tid}`) : `topic:${tids}`
    );
};
      Severity: Major
      Found in src/topics/index.js and 2 other locations - About 55 mins to fix
      src/categories/index.js on lines 27..31
      src/posts/index.js on lines 30..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      Topics.getMainPost = async function (tid, uid) {
    const mainPosts = await Topics.getMainPosts([tid], uid);
    return Array.isArray(mainPosts) && mainPosts.length ? mainPosts[0] : null;
};
      Severity: Minor
      Found in src/topics/index.js and 2 other locations - About 35 mins to fix
      src/posts/topics.js on lines 29..32
      src/topics/teaser.js on lines 162..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status