Sign upLogin

NodeBB/NodeBB

View on GitHub
Star
src/user/interstitials.js

Summary

Maintainability
C
1 day
Test Coverage

Function email has a Cognitive Complexity of 67 (exceeds 10 allowed). Consider refactoring.
Open

Interstitials.email = async (data) => {
    if (!data.userData) {
        throw new Error('[[error:invalid-data]]');
    }
    if (!data.userData.updateEmail) {
Severity: Minor
Found in src/user/interstitials.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function email has 95 lines of code (exceeds 75 allowed). Consider refactoring.
Open

Interstitials.email = async (data) => {
    if (!data.userData) {
        throw new Error('[[error:invalid-data]]');
    }
    if (!data.userData.updateEmail) {
Severity: Major
Found in src/user/interstitials.js - About 1 hr to fix

    Function gdpr has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
    Open

    Interstitials.gdpr = async function (data) {
    if (!meta.config.gdpr_enabled || (data.userData && data.userData.gdpr_consent)) {
        return data;
    }
    if (!data.userData) {
    Severity: Minor
    Found in src/user/interstitials.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status