Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/shopping_cart/public/cart.js

Summary

Maintainability
D
2 days
Test Coverage

File cart.js has 316 lines of code (exceeds 250 allowed). Consider refactoring.
Open

shopping_cart = {
}

function Cart(config) {
  var $ = jQuery;
Severity: Minor
Found in plugins/shopping_cart/public/cart.js - About 3 hrs to fix

    Function addToList has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Cart.prototype.addToList = function(products, clear) {
    if( clear ) this.itemsBox.empty();
    var me = this;
    this.productsLength = products.length;
    for( var item,i=0; item=products[i]; i++ ) {
    Severity: Minor
    Found in plugins/shopping_cart/public/cart.js - About 1 hr to fix

      Function updateQuantity has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Cart.prototype.updateQuantity = function(input, itemId, quantity) {
    if(this.disabled) return alert(Cart.l10n.waitLastRequest);
    quantity = parseInt(quantity);
    input.disabled = true;
    var originalBg = input.style.backgroundImage;
      Severity: Minor
      Found in plugins/shopping_cart/public/cart.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          Cart.prototype.show = function(register) {
    if(register) {
      this.ajax({
        url: '/plugin/shopping_cart/show',
        dataType: 'json',
        Severity: Major
        Found in plugins/shopping_cart/public/cart.js and 1 other location - About 5 hrs to fix
        plugins/shopping_cart/public/cart.js on lines 256..271

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 148.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          Cart.prototype.hide = function(register) {
    if(register) {
      this.ajax({
        url: '/plugin/shopping_cart/hide',
        dataType: 'json',
        Severity: Major
        Found in plugins/shopping_cart/public/cart.js and 1 other location - About 5 hrs to fix
        plugins/shopping_cart/public/cart.js on lines 239..255

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 148.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status