Sign upLogin

Noosfero/noosfero

View on GitHub
Star
plugins/sniffer/public/javascripts/sniffer.js

Summary

Maintainability
D
1 day
Test Coverage

File sniffer.js has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

sniffer = {

  search: {

    filters: { __categoryIds: [], distance: 0, circle: undefined, homePosition: undefined },
Severity: Minor
Found in plugins/sniffer/public/javascripts/sniffer.js - About 4 hrs to fix

    Function add has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            add: function(profile, filtered) {
          if (filtered == undefined)
            filtered = true;

          var sp = profile.suppliersProducts;
    Severity: Minor
    Found in plugins/sniffer/public/javascripts/sniffer.js - About 1 hr to fix

      Function loadSearchInput has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          loadSearchInput: function (options) {
      var input = jQuery(".sniffer-search-input");
      input.hint();
      input.autocomplete({
        source: options.sourceUrl,
      Severity: Minor
      Found in plugins/sniffer/public/javascripts/sniffer.js - About 1 hr to fix

        Function fill has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                fill: function (marker) {
          // close all opened markers before opening a new one
          jQuery.each(sniffer.search.map.markerList, function(index, marker) {
            if (!(typeof marker.infoBox === 'undefined'))
              marker.infoBox.close();
        Severity: Minor
        Found in plugins/sniffer/public/javascripts/sniffer.js - About 1 hr to fix

          Function loadSearchInput has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              loadSearchInput: function (options) {
      var input = jQuery(".sniffer-search-input");
      input.hint();
      input.autocomplete({
        source: options.sourceUrl,
          Severity: Minor
          Found in plugins/sniffer/public/javascripts/sniffer.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function add has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                  add: function(profile, filtered) {
          if (filtered == undefined)
            filtered = true;

          var sp = profile.suppliersProducts;
          Severity: Minor
          Found in plugins/sniffer/public/javascripts/sniffer.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function select has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  select: function (event, ui) {
          category = {id: ui.item.value, name: ui.item.label, interest_type: 'supplier'};
          if (sniffer.search.category.exists(category.id))
            sniffer.search.category.updateInterestType(category.id);
          else
          Severity: Minor
          Found in plugins/sniffer/public/javascripts/sniffer.js - About 1 hr to fix

            Function create has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    create: function (lat, lng, title, icon, url_or_function) {
            Severity: Minor
            Found in plugins/sniffer/public/javascripts/sniffer.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        if (mapPoints[point_str]) {
            lng += (Math.random() - 0.5) * 0.02;
            lat += (Math.random() - 0.5) * 0.02;
          } else {
            mapPoints[point_str] = true;
              Severity: Major
              Found in plugins/sniffer/public/javascripts/sniffer.js and 1 other location - About 1 hr to fix
              public/javascripts/google_maps.js on lines 15..20

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status