Sign upLogin

NuAxis/samwise

View on GitHub
Star
spec/samwise/duns_spec.js

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should format an 7 digit Duns into a 13 digit Duns', function() {
      var formattedDuns = Samwise.Duns.format(SEVEN_DUNS);

      expect(formattedDuns.length).to.equal(13);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 2 other locations - About 1 hr to fix
spec/samwise/duns_spec.js on lines 75..79
spec/samwise/duns_spec.js on lines 81..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should format an 8 digit Duns into a 13 digit Duns', function() {
      var formattedDuns = Samwise.Duns.format(EIGHT_DUNS);

      expect(formattedDuns.length).to.equal(13);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 2 other locations - About 1 hr to fix
spec/samwise/duns_spec.js on lines 69..73
spec/samwise/duns_spec.js on lines 81..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should format a 9 digit Duns into a 13 digit Duns', function() {
      var formattedDuns = Samwise.Duns.format(NINE_DUNS);

      expect(formattedDuns.length).to.equal(13);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 2 other locations - About 1 hr to fix
spec/samwise/duns_spec.js on lines 69..73
spec/samwise/duns_spec.js on lines 75..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return true when the Duns is 7 digits (not counting hyphens)', function() {
      var SEVEN_DUNSTest = Samwise.Duns.isValid(SEVEN_DUNS);

      expect(SEVEN_DUNSTest).to.equal(true);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 4 other locations - About 50 mins to fix
spec/samwise/duns_spec.js on lines 25..29
spec/samwise/duns_spec.js on lines 31..35
spec/samwise/duns_spec.js on lines 37..41
spec/samwise/duns_spec.js on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return true when the Duns is 8 digits (not counting hyphens)', function() {
      var EIGHT_DUNSTest = Samwise.Duns.isValid(EIGHT_DUNS);

      expect(EIGHT_DUNSTest).to.equal(true);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 4 other locations - About 50 mins to fix
spec/samwise/duns_spec.js on lines 25..29
spec/samwise/duns_spec.js on lines 31..35
spec/samwise/duns_spec.js on lines 43..47
spec/samwise/duns_spec.js on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return true when the Duns is 9 digits (not counting hyphens)', function() {
      var NINE_DUNSTest = Samwise.Duns.isValid(NINE_DUNS);

      expect(NINE_DUNSTest).to.equal(true);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 4 other locations - About 50 mins to fix
spec/samwise/duns_spec.js on lines 25..29
spec/samwise/duns_spec.js on lines 37..41
spec/samwise/duns_spec.js on lines 43..47
spec/samwise/duns_spec.js on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return true when the Duns is 13 digits (not counting hyphens)', function() {
      var THIRTEEN_DUNSTest = Samwise.Duns.isValid(THIRTEEN_DUNS);

      expect(THIRTEEN_DUNSTest).to.equal(true);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 4 other locations - About 50 mins to fix
spec/samwise/duns_spec.js on lines 31..35
spec/samwise/duns_spec.js on lines 37..41
spec/samwise/duns_spec.js on lines 43..47
spec/samwise/duns_spec.js on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('should return false when the Duns contains letters', function() {
      var LETTERS_DUNSTest = Samwise.Duns.isValid(LETTERS_DUNS);

      expect(LETTERS_DUNSTest).to.equal(false);
    });
Severity: Major
Found in spec/samwise/duns_spec.js and 4 other locations - About 50 mins to fix
spec/samwise/duns_spec.js on lines 25..29
spec/samwise/duns_spec.js on lines 31..35
spec/samwise/duns_spec.js on lines 37..41
spec/samwise/duns_spec.js on lines 43..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status