Sign upLogin

OCA/server-tools

View on GitHub
Star
field_rrule/static/src/js/field_rrule.js

Summary

Maintainability
F
4 days
Test Coverage

Function field_rrule has 300 lines of code (exceeds 25 allowed). Consider refactoring.
Open

openerp.field_rrule = function(instance)
{
    instance.field_rrule.FieldRRule = instance.web.form.AbstractField
    .extend(instance.web.form.ReinitializeFieldMixin, {
        template: 'FieldRRule',
Severity: Major
Found in field_rrule/static/src/js/field_rrule.js - About 1 day to fix

    Function field_rrule has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

    openerp.field_rrule = function(instance)
{
    instance.field_rrule.FieldRRule = instance.web.form.AbstractField
    .extend(instance.web.form.ReinitializeFieldMixin, {
        template: 'FieldRRule',
    Severity: Minor
    Found in field_rrule/static/src/js/field_rrule.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File field_rrule.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //-*- coding: utf-8 -*-
//© 2016 Therp BV <http://therp.nl>
//License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

openerp.field_rrule = function(instance)
    Severity: Minor
    Found in field_rrule/static/src/js/field_rrule.js - About 3 hrs to fix

      Function datetimepicker_format has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              datetimepicker_format: function(odoo_format)
        {
            var result = '',
                map = {
                    '%a': 'D',
      Severity: Minor
      Found in field_rrule/static/src/js/field_rrule.js - About 1 hr to fix

        Function input_changed has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                input_changed: function(e, noreset)
        {
            var input = jQuery(e.currentTarget),
                current_item = input
                    .parentsUntil('form', 'table.rule_item'),
        Severity: Minor
        Found in field_rrule/static/src/js/field_rrule.js - About 1 hr to fix

          Function reset_fields has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  reset_fields: function(rule, current_item, field)
        {
            // for some fields, we should reset some other fields when they
            // were changed
            if(field == 'freq')
          Severity: Minor
          Found in field_rrule/static/src/js/field_rrule.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    format_field_freq: function(frequency)
        {
            switch(parseInt(frequency))
            {
                case 0: return instance.web._t('Yearly');
            Severity: Major
            Found in field_rrule/static/src/js/field_rrule.js and 1 other location - About 5 hrs to fix
            field_rrule/static/src/js/field_rrule.js on lines 267..279

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    format_field_weekday: function(weekday)
        {
            switch(parseInt(weekday))
            {
                case 0: return instance.web._t('Monday');
            Severity: Major
            Found in field_rrule/static/src/js/field_rrule.js and 1 other location - About 5 hrs to fix
            field_rrule/static/src/js/field_rrule.js on lines 280..292

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status