OmarElGabry/chat.io

View on GitHub

Showing 5 of 9 total issues

Function ioEvents has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var ioEvents = function(io) {

    // Rooms namespace
    io.of('/rooms').on('connection', function(socket) {

Severity: Major
Found in app/socket/index.js - About 2 hrs to fix

    Function init has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var init = function () {
    
        if(process.env.NODE_ENV === 'production') {
            var redisURI         = require('url').parse(process.env.REDIS_URL);
            var redisPassword     = redisURI.auth.split(':')[1];
    Severity: Minor
    Found in app/config/index.js - About 1 hr to fix

      Function init has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var init = function(){
      
          // Serialize and Deserialize user instances to and from the session.
          passport.serializeUser(function(user, done) {
              done(null, user.id);
      Severity: Minor
      Found in app/auth/index.js - About 1 hr to fix

        Function chat has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          chat: function(roomId, username){
            
            var socket = io('/chatroom', { transports: ['websocket'] });
        
              // When socket connects, join the current chatroom
        Severity: Minor
        Found in public/js/main.js - About 1 hr to fix

          Function updateUsersList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              updateUsersList: function(users, clear){
                  if(users.constructor !== Array){
                    users = [users];
                  }
          
          
          Severity: Minor
          Found in public/js/main.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language