OpenC3/cosmos

View on GitHub

Showing 842 of 1,379 total issues

Consider simplifying this complex logical expression.
Open

            if (
                (plan_type == "GROUP_SETUP" and group_class == plan_group_class)
                or (plan_type == "GROUP_TEARDOWN" and group_class == plan_group_class)
                or (plan_script and group_class == plan_group_class)
            ):
Severity: Major
Found in openc3/python/openc3/script/suite.py - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

                if not (
                    (endianness == "LITTLE_ENDIAN")
                    and ((data_type == "INT") or (data_type == "UINT"))
                    and (
                        # Not byte aligned with an even bit size
    Severity: Major
    Found in openc3/python/openc3/accessors/binary_accessor.py - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

                if !((endianness == :LITTLE_ENDIAN) &&
                       ((data_type == :INT) || (data_type == :UINT)) &&
                       # Not byte aligned with an even bit size
                       (!((byte_aligned(bit_offset)) && (even_bit_size(bit_size)))) &&
                       (lower_bound < buffer_length)
      Severity: Major
      Found in openc3/lib/openc3/accessors/binary_accessor.rb - About 40 mins to fix

        Function diff_bisectSplit_ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          text1,
          text2,
          x,
          y,
          deadline,

          Function display_screen has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def display_screen(target_name, screen_name, x=None, y=None, scope=OPENC3_SCOPE):
          Severity: Minor
          Found in openc3/python/openc3/script/screen.py - About 35 mins to fix

            Function get_packets has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def get_packets(
            Severity: Minor
            Found in openc3/python/openc3/script/telemetry.py - About 35 mins to fix

              Function inject_tlm has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def inject_tlm(
              Severity: Minor
              Found in openc3/python/openc3/script/telemetry.py - About 35 mins to fix

                Function addConnector has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  acediff,
                  leftStartLine,
                  leftEndLine,
                  rightStartLine,
                  rightEndLine,
                Severity: Minor
                Found in openc3-cosmos-init/plugins/packages/openc3-cosmos-ace-diff/src/index.js - About 35 mins to fix

                  Function limits_change_callback has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def limits_change_callback(self, packet, item, old_limits_state, value, log_change):
                  Severity: Minor
                  Found in openc3/python/openc3/microservices/decom_microservice.py - About 35 mins to fix

                    Function showDiff has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function showDiff(acediff, editor, startLine, endLine, className) {
                    Severity: Minor
                    Found in openc3-cosmos-init/plugins/packages/openc3-cosmos-ace-diff/src/index.js - About 35 mins to fix

                      Function computeDiff has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function computeDiff(acediff, diffType, offsetLeft, offsetRight, diffText) {
                      Severity: Minor
                      Found in openc3-cosmos-init/plugins/packages/openc3-cosmos-ace-diff/src/index.js - About 35 mins to fix

                        Function inject_tlm has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def inject_tlm(
                        Severity: Minor
                        Found in openc3/python/openc3/topics/decom_interface_topic.py - About 35 mins to fix

                          Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def __init__(self, router, tlm, logger=None, metric=None, scope=None):
                          Severity: Minor
                          Found in openc3/python/openc3/microservices/interface_microservice.py - About 35 mins to fix

                            Function get_cmd_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def get_cmd_item(cls, target_name, packet_name, param_name, type="WITH_UNITS", scope=OPENC3_SCOPE):
                            Severity: Minor
                            Found in openc3/python/openc3/topics/command_decom_topic.py - About 35 mins to fix

                              Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def add(
                              Severity: Minor
                              Found in openc3/python/openc3/script/web_socket_api.py - About 35 mins to fix

                                Function wait_expression has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                def wait_expression(
                                Severity: Minor
                                Found in openc3/python/openc3/script/api_shared.py - About 35 mins to fix

                                  Function _check_eval has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  def _check_eval(target_name, packet_name, item_name, comparison_to_eval, value):
                                  Severity: Minor
                                  Found in openc3/python/openc3/script/api_shared.py - About 35 mins to fix

                                    Function start has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        def start(
                                    Severity: Minor
                                    Found in openc3/python/openc3/script/suite_results.py - About 35 mins to fix

                                      Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          def __init__(self, interface, tlm, logger=None, metric=None, scope=None):
                                      Severity: Minor
                                      Found in openc3/python/openc3/microservices/interface_microservice.py - About 35 mins to fix

                                        Function set_packet has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                            def set_packet(
                                        Severity: Minor
                                        Found in openc3/python/openc3/models/target_model.py - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language