OpenC3/cosmos

View on GitHub
openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js

Summary

Maintainability
C
1 day
Test Coverage

Function modifyLimits has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    modifyLimits(limitsSettings) {
      // By default the red bars take 10% of the display
      this.redLow = 10
      this.redHigh = 10

    Function calcLimits has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        calcLimits(limitsSettings) {
          if (!limitsSettings) {
            return
          }
          this.yellowLow = Math.round(

      Function calcPosition has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          calcPosition(value, limitsSettings) {
            if (!value || !limitsSettings) {
              return
            }
            let lowValue = limitsSettings[0] - 10 * this.scale

        Avoid too many return statements within this function.
        Open

                  return result

          Avoid too many return statements within this function.
          Open

                    return 0

            Avoid too many return statements within this function.
            Open

                      return 100

              Avoid too many return statements within this function.
              Open

                      return 100

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (limitsSettings[3] >= this.maxValue) {
                          limitsSettings[3] = this.maxValue
                          // No red high will be displayed
                          this.redHigh = 0
                        }
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 117..121

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (limitsSettings[0] <= this.minValue) {
                          limitsSettings[0] = this.minValue
                          // No red low will be displayed
                          this.redLow = 0
                        }
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 148..152

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        if (limitsSettings.length > 4 && limitsSettings[5] <= this.minValue) {
                          limitsSettings[5] = this.minValue
                        }
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 131..133
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 153..155
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 156..158

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        if (limitsSettings.length > 4 && limitsSettings[4] <= this.minValue) {
                          limitsSettings[4] = this.minValue
                        }
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 134..136
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 153..155
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 156..158

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        if (limitsSettings.length > 4 && limitsSettings[5] >= this.maxValue) {
                          limitsSettings[5] = this.maxValue
                        }
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 131..133
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 134..136
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 153..155

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        if (limitsSettings.length > 4 && limitsSettings[4] >= this.maxValue) {
                          limitsSettings[4] = this.maxValue
                        }
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 131..133
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 134..136
                openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/widgets/BarColumn.js on lines 156..158

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status