Sign upLogin

Opetushallitus/eperusteet-opintopolku

View on GitHub
Star

Showing 413 of 606 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

            function setParentOppiaineHeader() {
                if (selected && selected.$oppiaine._oppiaine) {
                    var found = _.find(items, function(item: any) {
                        return item.$oppiaine && "" + item.$oppiaine.id === "" + selected.$oppiaine._oppiaine;
                    });
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts and 2 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts on lines 52..61
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 51..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                        if (_.size(opskohtaiset) === 1) {
                                            $scope.misc.koodinimet[koodi.route].nimi =
                                                opskohtaiset[0].tekstiKappale.nimi;
                                            $scope.misc.koodinimet[koodi.route].url = $state.href("root.amops.osa", {
                                                opsId: opskohtaiset[0].owner.id,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts on lines 173..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.perusopetus.tiedot", {
        url: "/tiedot",
        templateUrl: "eperusteet-esitys/views/tiedot.html",
        controller: Controllers.epEsitysTiedotController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/perusopetus/tiedot/state.ts and 2 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/lisaopetus/tiedot/state.ts on lines 1..15
eperusteet-opintopolku-app/yo/app/states/perusvalmistava/tiedot/state.ts on lines 1..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                    if (_.size(koodi) === 1) {
                                        $scope.misc.koodinimet[koodi.route].nimi = koodi[0].tekstiKappale.nimi;
                                        $scope.misc.koodinimet[koodi.route].url = $state.href("root.amops.osa", {
                                            opsId: koodi[0].owner.id,
                                            osaId: koodi[0].id
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/amops/osa/state.ts on lines 184..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

            function setParentOppiaineHeader() {
                if (selected && selected.$oppiaine._oppiaine) {
                    var found = _.find(items, function(item: any) {
                        return item.$oppiaine && "" + item.$oppiaine.id === "" + selected.$oppiaine._oppiaine;
                    });
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/lukiostateservice.ts and 2 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 55..64
eperusteet-opintopolku-app/yo/app/scripts/common/services/lukioopsstateservice.ts on lines 51..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                if (item.$osa) {
                    item.$selected = "" + $stateParams.tekstikappaleId === "" + item.$osa.id;
                    item.$hidden = item.depth > 0;
                } else if (item.id === "laajaalaiset") {
                    item.$selected = $state.is(epEsitysSettings.perusopetusState + ".laajaalaiset");
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts on lines 71..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                } else if (item.$osa) {
                    item.$selected = "" + $stateParams.tekstikappaleId === "" + item.$osa.id;
                    item.$hidden = item.depth > 0;
                } else if (item.id === "laajaalaiset") {
                    item.$selected = $state.is(epEsitysSettings.perusopetusState + ".laajaalaiset");
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/stateservice.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opssivunaviutils.ts on lines 78..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.lukio.oppiaine", {
        url: "/oppiaine/:oppiaineId",
        templateUrl: "eperusteet-esitys/views/lukiooppiaine.html",
        controller: Controllers.epLukioOppiaineController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/lukio/oppiaine/state.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/perusopetus/vlkoppiaine/state.ts on lines 1..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.perusopetus.vlkoppiaine", {
        url: "/vuosiluokkakokonaisuus/:vlkId/oppiaine/:oppiaineId",
        templateUrl: "eperusteet-esitys/views/vlkoppiaine.html",
        controller: Controllers.epPerusopetusVlkOppiaineController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/perusopetus/vlkoppiaine/state.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/lukio/oppiaine/state.ts on lines 1..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        var createYears = function(numbs, tunniste) {
            var start = parseInt(numbs[0]);
            var stop = numbs[1] ? parseInt(numbs[1]) + 1 : start + 1;
            for (var i = start; i < stop; i++) {
                menu.push({
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/views/ops/opsutils.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/common/services/opsmenubuilders.ts on lines 20..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const createYears = (numbs, tunniste) => {
            let start = parseInt(numbs[0]);
            let stop = numbs[1] ? parseInt(numbs[1]) + 1 : start + 1;
            for (let i = start; i < stop; i++) {
                menu.push({
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/scripts/common/services/opsmenubuilders.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/scripts/views/ops/opsutils.ts on lines 33..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.esiopetus.tiedot", {
        url: "/tiedot",
        templateUrl: "eperusteet-esitys/views/tiedot.html",
        controller: Controllers.epEsitysTiedotController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/esiopetus/tiedot/state.ts and 3 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/opas/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/tpo/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/varhaiskasvatus/tiedot/state.ts on lines 1..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.varhaiskasvatus.tiedot", {
        url: "/tiedot",
        templateUrl: "eperusteet-esitys/views/tiedot.html",
        controller: Controllers.epEsitysTiedotController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/varhaiskasvatus/tiedot/state.ts and 3 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/esiopetus/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/opas/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/tpo/tiedot/state.ts on lines 1..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.tpo.tiedot", {
        url: "/tiedot",
        templateUrl: "eperusteet-esitys/views/tiedot.html",
        controller: Controllers.epEsitysTiedotController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/tpo/tiedot/state.ts and 3 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/esiopetus/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/opas/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/varhaiskasvatus/tiedot/state.ts on lines 1..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  @Getter((state, getters) => {
    if (getters.flattenedSidenav && state.currentRoute) {
      for (const node of getters.flattenedSidenav) {
        if (node.location && _.isMatch(state.currentRoute, node.location)) {
          return node || null;
Severity: Major
Found in src/stores/PerusteDataStore.ts and 2 other locations - About 3 hrs to fix
src/stores/OpetussuunnitelmaDataStore.ts on lines 339..349
src/stores/ToteutussuunnitelmaDataStore.ts on lines 204..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  @Getter((state, getters) => {
    if (getters.flattenedSidenav && state.currentRoute) {
      for (const node of getters.flattenedSidenav) {
        if (node.location && _.isMatch(state.currentRoute, node.location)) {
          return node || null;
Severity: Major
Found in src/stores/ToteutussuunnitelmaDataStore.ts and 2 other locations - About 3 hrs to fix
src/stores/OpetussuunnitelmaDataStore.ts on lines 339..349
src/stores/PerusteDataStore.ts on lines 223..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

angular.module("app").config($stateProvider =>
    $stateProvider.state("root.opas.tiedot", {
        url: "/tiedot",
        templateUrl: "eperusteet-esitys/views/tiedot.html",
        controller: Controllers.epEsitysTiedotController,
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/states/opas/tiedot/state.ts and 3 other locations - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/states/esiopetus/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/tpo/tiedot/state.ts on lines 1..14
eperusteet-opintopolku-app/yo/app/states/varhaiskasvatus/tiedot/state.ts on lines 1..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  @Getter((state, getters) => {
    if (getters.flattenedSidenav && state.currentRoute) {
      for (const node of getters.flattenedSidenav) {
        if (node.location && _.isMatch(state.currentRoute, node.location)) {
          return node || null;
Severity: Major
Found in src/stores/OpetussuunnitelmaDataStore.ts and 2 other locations - About 3 hrs to fix
src/stores/PerusteDataStore.ts on lines 223..233
src/stores/ToteutussuunnitelmaDataStore.ts on lines 204..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                function updateFooter() {
                    scope.footerContent = scope.footer ? $compile(scope.footer)(scope) : "";
                    const el = element.find("#sivunavi-footer-content");
                    el.empty().removeClass("has-content");
                    if (scope.footer) {
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/sivunavigaatio.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts on lines 37..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            function updateFooter() {
                scope.footerContent = scope.footer ? $compile(scope.footer)(scope) : "";
                var el = element.find("#sivunavi-footer-content");
                el.empty().removeClass("has-content");
                if (scope.footer) {
Severity: Major
Found in eperusteet-opintopolku-app/yo/app/eperusteet-esitys/views/controllers/lukio.ts and 1 other location - About 3 hrs to fix
eperusteet-opintopolku-app/yo/app/eperusteet-esitys/services/sivunavigaatio.ts on lines 260..267

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language