Otetz/requests_proxy_adapter

View on GitHub

Showing 2 of 2 total issues

Function build_response has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def build_response(self, req, resp):
        """
        Builds a :class:`Response <requests.Response>` object from a urllib3 response.

        Build response are doing by parent class :class:`HTTPAdapter`. This code detect 500 in response status code and
Severity: Minor
Found in requests_proxy_adapter/api.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, retries=3, backoff_factor=0.3, status_forcelist=(500, 502, 504), *args, **kwargs):
Severity: Minor
Found in requests_proxy_adapter/api.py - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language