Sign upLogin

PRX/pmp

View on GitHub
Star

Showing 2 of 2 total issues

Class CollectionDocument has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class CollectionDocument

    include Configuration
    include Connection
    include Parser
Severity: Minor
Found in lib/pmp/collection_document.rb - About 2 hrs to fix

    Method request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def request(method, url, body=nil) # :nodoc:

      unless ['/', ''].include?(URI::parse(url).path)
        setup_oauth_token
      end
    Severity: Minor
    Found in lib/pmp/collection_document.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language